When using the VisualEditor and having the Preference "Edit pages on double click (requires JavaScript)" on, the Editor is stopped as soon as one tries to select a word (= double click)or paragraph (= triple click). The javascript for "Edit pages on double click (requires JavaScript)" needs to be modified to check whether in VisualEditor mode or not (all works ok when in normal editing mode.
Version: unspecified
Severity: minor
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Krinkle | T45023 VisualEditor: Handling of double click when preference "Edit pages on double click" is active | |||
| Resolved | Krinkle | T45052 mediawiki.action.view.dblClickEdit.dblClickEdit should trigger ca-edit click instead opening URL directly |
Immediate solution is to suppress the JS when VE is active, but not when in read mode.
Longer-term, this should be refactored so that users have a "default" editor, and this kind of thing triggers whichever one you've chosen.
The surface should just bind a click handler and prevent the event from bubbling up to the handler that mediawiki.action.view.dblClickEdit attaches to $content.
This has been fixed by Ie8a35700bc9e in mediawiki core.
In the current configuration however out tabLayout is in "add" more (when this bug was reported, we were still in "replace" mode).
In "add" mode we add an extra tab for "VisualEditor", so the original "Edit" is still there, which is the default. And double-clicking in the content area will (as it should) trigger the original editor.
If/when we enable the "replace" mode again, since this bug is fixed, double-clicking will trigger VisualEditor as expected.
So, although it can't be seen right now, as the feature is not activated right now, this bug as been fixed.
To verify, edit ve.init.mw.ViewPageTarget.js and set this.tabLayout = "replace";.