Page MenuHomePhabricator

[Task] Edit auto summary not substituted in email notification
Open, LowPublic

Description

I received a notification by email for this change: http://www.wikidata.org/w/index.php?title=Q4524&diff=1382958&oldid=1145856 (added Spanish label). On-wiki the summary auto comment is correctly substituted but in the email the summary shows up as:

"Editor's summary: /* wbsetdescription-set:1|es */ especie de mamífero"

Details

Reference
bz43044

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:10 AM
bzimport set Reference to bz43044.
bzimport added a subscriber: Unknown Object (MLST).

Problem over here is that these emails are plain text ones, while our (formatted) autocomments always consist of html.
We could fix this by either making core's autocomment stuff more flexible so that it also supports a plain text format (sounds very tedious) or by introducing a hook into UserMailer where we can add a custom format for emails (that would be both tedious and messy).

I suggest to WONTFIX this.

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).Dec 1 2014, 2:31 PM
thiemowmde renamed this task from edit auto summary not substituted in email notification to [Task] Edit auto summary not substituted in email notification.Aug 13 2015, 2:45 PM
thiemowmde lowered the priority of this task from High to Low.
thiemowmde updated the task description. (Show Details)
thiemowmde set Security to None.
thiemowmde removed subscribers: Wikidata-bugs, Denny.
Tacsipacsi added a subscriber: Tacsipacsi.

With T215422: Migrate Wikibase to use comment_data field instead of SummaryFormatter implemented, the comment_text will be the summary parsed in the content language, so if the mailer uses that (I suppose it does), this bug will be automatically resolved—although the summary will be in content language even if the user’s UI language is different, this is consistent with the rest of the email.