Page MenuHomePhabricator

[Regression] E-Mail notification mail: page names with "&" come as "&"
Closed, ResolvedPublic

Description

I noticed with

that "&" in pagenames are sent as (e-notif arrives with) "&"

This is a regression.


Version: 1.21.x
Severity: normal

Details

Reference
bz43070

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:12 AM
bzimport set Reference to bz43070.
Wikinaut created this task.Dec 13 2012, 2:06 PM

Yes, just noticed this as well:

Outreach Wiki page GLAM/Tools & Requests has been changed by Tpt

Dear Nemo bis,

The Outreach Wiki page GLAM/Tools & Requests has been changed on
6 January 2013 by Tpt, see
http://outreach.wikimedia.org/wiki/GLAM/Tools_%26_Requests for the
current revision.

Can the person who broke the email notification subject line coding please fix this regression? Thanks in advance.

"MediaWiki page Manual:MediaWiki Developer's Guide has been changed by Qgil"

This does not sound like "Should be fixed next by a team and certainly before the next deployment" so I reset "Highest priority" to "High".

Looking at the code my wild guess would be the lines after
"# Now build message's subject and body" in
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blobdiff;f=includes/UserMailer.php;h=daf74357a354417328e11490cb16fca4427f0941;hp=b9ce9e0574d14122fc5fc1c9c0772a61658b8352;hb=494529503b41142d68d52c458a44b82577699785;hpb=8199d6121aeadb4a6c9c6975b804e3e55e112fd5

The patch was written by bsitu, hence CC'ing.

bsitu wrote:

They should have been fixed in here along with the backward compatibility of $CHANGEDORCREATED: https://gerrit.wikimedia.org/r/#/c/39179/1/includes/UserMailer.php, I updated escaped() to text()

(In reply to comment #5)

They should have been fixed in here along with the backward compatibility of
$CHANGEDORCREATED:
https://gerrit.wikimedia.org/r/#/c/39179/1/includes/UserMailer.php, I updated
escaped() to text()

Not sure how to interpret "they should have been fixed", so can anybody confirm if this is still a problem, please?
T. Gries, Nemo_bis?

The Outreach Wiki page GLAM/Tools & Requests has been changed on
20 March 2013 by Nemo quater, see
http://outreach.wikimedia.org/wiki/GLAM/Tools_%26_Requests for the
current revision.