Page MenuHomePhabricator

VisualEditor: Elements nested inside Aliens with z-index appear on top of the zebra pattern
Closed, ResolvedPublic

Description

Try editing the page [[:en:Buri_Ram_Airport]] with VisualEditor. Mouse over the infobox. There's an element that sticks above the alien marking, because it has a z-index attribute.

I don't know how best to fix this, I assume it would be bad to simply set z-index=1000 and be on your way, but it's an inconsistent appearance and something to be fixed eventually.

I suspect this may also be a good beginner bug, so if someone from the VE team can mark this as easy, then we can leave it for a newcomer.


Version: unspecified
Severity: normal
URL: http://en.wikipedia.org/wiki/Buri_Ram_Airport

Details

Reference
bz43098

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:45 AM
bzimport set Reference to bz43098.

Sorry, setting web browser in case it matters.

The following CSS rule exists:

.ve-ce-alienBlockNode, .ve-ce-alienInlineNode,
.ve-ce-alienBlockNode *, .ve-ce-alienInlineNode * {

position: relative !important;
top: 0 !important;
left: 0 !important;
bottom: 0 !important;
right: 0 !important;

}

They have position relative, so the z-index within is relative and constraint within the alien.

However that isn't the case. This is because the top node (alienBlockNode, not alienBlockNode *) needs z-index: 0; to complete this feature. It is the combination of z-index: 0; and position: relative; that makes it work.

It was presumably forgotten because it needs to be on a separate rule (not inside the one above, since that would set z-index: 0; on all blocks, thus destroying the order of elements within the alien).

You guys have no concept of leaving a simple bug for new contributors? :)

Not to worry, I'll go find more. Thanks Rob!

Change-Id: I889074a659483ce3d48380be5f50f80abb573286