With the new AJAX patrol, after clicking the patrol button the text is replaced with the loading icon, but the brackets around it are kept until the action is completed, which is a bit ugly.
Low priority because it's usually so quick as to go unnoticed.
Version: 1.21.x
Severity: enhancement
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Duplicate | Krinkle | T33270 Proper AJAX rollback functionality in core | |||
| Open | Feature | None | T45164 Remove square brackets in patrol link after click |
It was actually implemented that way on purpose (changing to 'enhancement').
But I can see how they look out of place. We do need to keep them though, for the case where the action fails (need to restore them, without hardcoding them in the client side error handler).
I'd say instead of removing the label, inserting the loader, and re-inserting the message on error. Let's hide the entire thing (display none), add the loader, and then either remove both or remove loader and show original.
(Moving the dependency to its "parent" bug because Krinkle complained about the dependency relation to the tracking bug being unclear.)