Page MenuHomePhabricator

SpecialPreferences page Misc issue (Misc shows options, which have no effect) incl. Patch
Closed, ResolvedPublic

Description

Problem arises e.g. with Enotif global switches.

Currently, the User Preference page Misc lists per default all toggles, which
have not been shown (used before in the algorithmic flow) on the other pages.

This is a problem, when for example $wgEnotifWatchList is set to false. The
corresponding user option must _not_ be shown, because checking the box would
not have any effect (because it is fully disabled).

As a work-around, you can apply this patch

add these lines at the beginning of function mainPrefsForm():

$this->mUsedToggles[ 'shownumberswatching' ] = true;
$this->mUsedToggles[ 'rccurrevonly' ] = true;
$this->mUsedToggles[ 'showupdated' ] = true;
$this->mUsedToggles[ 'enotifwatchlistpages' ] = true;
$this->mUsedToggles[ 'enotifusertalkpages' ] = true;
$this->mUsedToggles[ 'enotifminoredits' ] = true;
$this->mUsedToggles[ 'enotifrevealaddr' ] = true;

Effect:
these toggles are marked as "used" (even when they are not shown), so that the
Misc page code doesn't show them at the end.


Version: 1.5.x
Severity: major

Details

Reference
bz2520

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 8:35 PM
bzimport set Reference to bz2520.
bzimport added a subscriber: Unknown Object (MLST).