Page MenuHomePhabricator

Special:Whatlinkshere's pagination is broken, won't let you get back to the first page after navigating to later ones
Closed, ResolvedPublic

Description

The (prev) links rely on having a &back= id from which they can be filled. This works neatly if you want to go back one level, but try and go back two in a row and the whole thing falls apart.

For example:, take https://en.wikipedia.org/w/index.php?title=Special:WhatLinksHere/Abacus . Now go forward (next) two times, and then back twice. In fact, you get trapped on page 2, because now there's no &back= id to use in the generation of a (prev) link.

WLH should probably copy other special pages and do "(prev)" using a dir=prev parameter.


Version: 1.21.x
Severity: normal

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:12 AM
bzimport set Reference to bz43509.
bzimport added a subscriber: Unknown Object (MLST).

Patch in Gerrit still waiting for review. :(

Change 41386 had a related patch set uploaded by Nemo bis:
(bug #43509) Special:Whatlinkshere pagination broken

https://gerrit.wikimedia.org/r/41386

Hi Jarry: Are you still available to move your patch forward?

Nemo: Do you think you can help move it forward?

Reseting assignee for now and adding the gerrit reviewers from the patch as a CC here.

The problem here is that you need a test instance with a lot of pages, that link to 1 page. Not many reviewers will have that.

(In reply to Derk-Jan Hartman from comment #5)

The problem here is that you need a test instance with a lot of pages, that
link to 1 page. Not many reviewers will have that.

Doing &limit=3 will help with that...

Jdforrester-WMF renamed this task from Special:Whatlinkshere pagination broken to Special:Whatlinkshere's pagination is broken, won't let you get back to the first page after navigating to later ones.Feb 9 2017, 12:37 AM
Jdforrester-WMF lowered the priority of this task from High to Medium.
Jdforrester-WMF removed a subscriber: wikibugs-l-list.

Change 675998 had a related patch set uploaded (by Aklapper; author: Mmeller95):

[mediawiki/core@master] Use pagination on Special:Whatlinkshere based on offset/dir system

https://gerrit.wikimedia.org/r/675998

Change 675998 had a related patch set uploaded (by Mmeller95; author: Mmeller95):

[mediawiki/core@master] Use pagination on Special:Whatlinkshere based on offset/dir system

https://gerrit.wikimedia.org/r/675998

Change 675998 merged by jenkins-bot:

[mediawiki/core@master] Use pagination on Special:Whatlinkshere based on offset/dir system

https://gerrit.wikimedia.org/r/675998

tstarling claimed this task.

Change 774470 had a related patch set uploaded (by Reedy; author: Mmeller95):

[mediawiki/core@REL1_36] Use pagination on Special:Whatlinkshere based on offset/dir system

https://gerrit.wikimedia.org/r/774470

Change 774470 abandoned by Reedy:

[mediawiki/core@REL1_36] Use pagination on Special:Whatlinkshere based on offset/dir system

Reason:

https://gerrit.wikimedia.org/r/774470