Page MenuHomePhabricator

VisualEditor: Whitespace preservation for list items not working
Closed, ResolvedPublic


For whatever reason (may be a bug in the DM, or in the seralizer, or in selser), whitespace preservation didn't work in this edit . The whitespace changes didn't show in the initial diff I was asked to verify, only in the final change.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:14 AM
bzimport set Reference to bz43543.

Confirm not happening in live - but /does/ happen with heads of VisualEditor and Parsoid (and MediaWiki) in testing. As Roan says, doesn't appear in diff, does appear in the final change.

It looks like this is happening because getDomFromData() somehow messes up the whitespace information. Then when getDomFromData() runs a second time (because you go back, change things, then diff again, or if you save after diffing), it sees inconsistent whitespace information and refuses to serialize it.

Related URL: (Gerrit Change Ic4c93510518163894201a693ab50331413715967)

(In reply to comment #3)

Related URL: (Gerrit Change

This commit fixes the bug. CC Gabriel and Subbu because they'd probably like to test it.

  • Bug 48367 has been marked as a duplicate of this bug. ***