VisualEditor: Diff viewer in weird state after Parsoid error
Closed, InvalidPublic

Description

Steps to reproduce:

  1. Open VE on a page
  2. Make changes
  3. Stop Parsoid
  4. Click "Review and save"
  5. Get an error dialog about Parsoid being down. Click "Cancel".

The box that's supposed to show the diff is left empty, but the "Something's wrong" and "Looks good to me" buttons are still there. I can dismiss the box with the up arrow to go back to editing, but we should be doing this (or at least *something*) automatically on failure.


Version: unspecified
Severity: minor

bzimport added a project: VisualEditor-MediaWiki.Via ConduitNov 22 2014, 1:29 AM
bzimport set Reference to bz43753.
Catrope created this task.Via LegacyJan 9 2013, 12:57 AM
Krenair added a comment.Via ConduitFeb 16 2014, 2:28 PM

Everything about this seems different now... "Review and save" I guess has become "Save page", and you only get an error about Parsoid being down when you then click "Review your changes". This dialog offers only an "OK" button which simply stops the loading of the review dialog. I don't see an empty diff or "Something's wrong"/"Looks good to me" buttons.

Is this bug still valid?

Jdforrester-WMF added a comment.Via ConduitFeb 18 2014, 8:55 PM

Yeah, we completely switched around the fetching logic here so that this is now INVALID; sorry.

Add Comment