Page MenuHomePhabricator

Do not bundle first-letters-root.ser with MediaWiki since it's only valid for one version of ICU
Closed, DeclinedPublic

Description

+++ This bug was initially created as a clone of Bug #43740 +++

We need to have versions of first-letters-root.ser that correspond to different versions of icu library. These are fairly easy to make (I believe). Simply need to feed maintinance/languages/generateCollationData.php different data files corresponding to different versions of unicode. (Need to double check that icu library is using the unicode files we think it is. I have a vague memory of it changing to some file from the CLDR stuff a couple versions ago)


Version: 1.21.x
Severity: normal

Details

Reference
bz43802

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:32 AM
bzimport set Reference to bz43802.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

. I have a vague memory of
it
changing to some file from the CLDR stuff a couple versions ago)

Specificly I'm thinking of the issue reported in bug 30675 - need to use allkeys_CLDR.txt instead for later versions.

It seems like we'd need at least five versions of this file, for Unicode 5.1, 5.2, 6.0, 6.1, and 6.2. (These are the version of Unicode generateCollationData.php supports after my changes, corresponding to ICU 4.0 .. 50.)

Therefore it seems like it would be a better idea not to bundle it, and just document that people wishing to use it should generate them themselves - the process is easy and just works.

And if we ever decide to start using ICU collation by default, these could be generated by the installer.

Thoughts?

[Summary: Generate first-letters-root.ser files for different versions of the ICU library --> Do not bundle first-letters-root.ser with MediaWiki since it's only valid for one version of ICU]

Submitted I5d2a4e7e, removing this from the the git repo.

CC-ing Tim.

Changeset abandoned. Wontfixing this; supposedly bug 43740 can and should be fixed in a different way.