Page MenuHomePhabricator
Create Task
Maniphest T45962

Special:ItemDisambiguation should include aliases in search, not just labels.
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When searching for Foo in Special:ItemDisambiguation, Items that have Foo as an aliases should be included in the result.

This can and should be achieved by querying the wb_terms table via the TermsCache interface.

Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=0
See Also:
T44686: Special:ItemDisambiguation should support case-insensitive matches.

Details

Reference
bz43962
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Do not use labels when linking item IDs on Special:ItemDisambiguationDaniel Kinzlermediawiki/extensions/Wikibasemaster+39 -22
Make Special:ItemDisambiguation match aliases.Daniel Kinzlermediawiki/extensions/Wikibasemaster+165 -66
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:14 AM
• bzimport added projects: MediaWiki-extensions-Wikibase-Repo, patch-welcome.
• bzimport set Reference to bz43962.
• bzimport added a subscriber: Unknown Object (MLST).
daniel created this task.Jan 14 2013, 4:14 PM
daniel added a comment.Jan 14 2013, 4:18 PM

Using TermsCache would also fix bug 42686.

daniel added a comment.Jan 14 2013, 4:19 PM

Note: The behavior of Special:ItemDisambiguation should be consistent with ApiSearchEntities.

matej_suchanek subscribed.Nov 24 2014, 2:42 PM
Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 2:27 PM
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Bugreporter added a parent task: T96040: Wikibase special pages (tracking).May 19 2015, 5:35 AM
daniel moved this task from incoming to needs discussion or investigation on the Wikidata board.Jun 29 2015, 8:37 AM
daniel moved this task from needs discussion or investigation to consider for next sprint on the Wikidata board.

With T90692 implemented, this should now be easy to do. I already have a patch in draft, with some UX questions remaining.

Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-06-30.Jun 30 2015, 1:35 PM
Tobi_WMDE_SW set Security to None.
Tobi_WMDE_SW edited a custom field.Jun 30 2015, 2:07 PM
gerritbot subscribed.Jul 2 2015, 4:19 PM

Change 222331 had a related patch set uploaded (by Daniel Kinzler):
Do not use labels when linking item IDs on Special:ItemDisambiguation

https://gerrit.wikimedia.org/r/222331

gerritbot added a project: Patch-For-Review.Jul 2 2015, 4:19 PM
gerritbot added a comment.Jul 2 2015, 4:34 PM

Change 221583 merged by jenkins-bot:
Make Special:ItemDisambiguation match aliases.

https://gerrit.wikimedia.org/r/221583

Diffusion mentioned this in rMEXT4eca4abb34a7: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 2 2015, 4:34 PM
Addshore mentioned this in rEWBA7db2fb031d44: Make Special:ItemDisambiguation match aliases..Jul 2 2015, 4:34 PM
gerritbot added a comment.Jul 2 2015, 4:37 PM

Change 222331 merged by jenkins-bot:
Do not use labels when linking item IDs on Special:ItemDisambiguation

https://gerrit.wikimedia.org/r/222331

Diffusion mentioned this in rMEXT62f441064288: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 2 2015, 4:37 PM
daniel mentioned this in rEWBAe30cd19229bd: Do not use labels when linking item IDs on Special:ItemDisambiguation.Jul 2 2015, 4:37 PM
Addshore closed this task as Resolved.Jul 2 2015, 8:54 PM
Addshore claimed this task.
Tobi_WMDE_SW moved this task from Backlog to Done on the Wikidata-Sprint-2015-06-30 board.Jul 3 2015, 4:05 PM
matej_suchanek updated the task description. (Show Details)Jul 8 2015, 6:17 AM
matej_suchanek removed a project: Patch-For-Review.
matej_suchanek mentioned this in T44686: Special:ItemDisambiguation should support case-insensitive matches..
matej_suchanek removed subscribers: gerritbot, matej_suchanek.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits