Page MenuHomePhabricator

Parser Fatal error: Call to a member function getLocalURL() on a non-object
Closed, ResolvedPublic

Description

Fatal error: Call to a member function getLocalURL() on a non-object in /usr/local/apache/common-local/php-1.21wmf7/includes/parser/Parser.php on line 5004


Version: 1.21.x
Severity: normal

Details

Reference
bz43964

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:14 AM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz43964.
Reedy created this task.Jan 14 2013, 6:12 PM
Reedy added a comment.Jan 14 2013, 6:14 PM

[14-Jan-2013 17:07:08] Fatal error: Call to a member function getLocalURL() on a non-object at /usr/local/apache/common-local/php-1.21wmf7/includes/parser/Parser.php on line 5004
Server: mw35
Method: POST
URL: http://en.wikipedia.org/w/index.php?title=User:Fraserlaidlaw/sandbox&action=submit
Backtrace:
#0 /usr/local/apache/common-local/php-1.21wmf7/includes/parser/Parser.php(5004): Parser::renderImageGallery()
#1 /usr/local/apache/common-local/php-1.21wmf7/includes/parser/CoreTagHooks.php(120): Parser->renderImageGallery('?File:southern-...', Array)
#2 [internal function]: CoreTagHooks::gallery('?File:southern-...', Array, Object(Parser), Object(PPFrame_DOM))
#3 /usr/local/apache/common-local/php-1.21wmf7/includes/parser/Parser.php(3863): call_user_func_array(Array, Array)
#4 /usr/local/apache/common-local/php-1.21wmf7/includes/parser/Preprocessor_DOM.php(1151): Parser->extensionSubstitution(Array, Object(PPFrame_DOM))
#5 /usr/local/apache/common-local/php-1.21wmf7/includes/parser/Parser.php(3086): PPFrame_DOM->expand(Object(PPNode_DOM), 0)
#6 /usr/local/apache/common-local/php-1.21wmf7/includes/parser/Parser.php(1157): Parser->replaceVariables('<gallery>?File:...')
#7 /usr/local/apache/common-local/php-1.21wmf7/includes/parser/Parser.php(385): Parser->internalParse('<gallery>?File:...')
#8 /usr/local/apache/common-local/php-1.21wmf7/includes/content/WikitextContent.php(299): Parser->parse('<gallery>?File:...', Object(Title), Object(ParserOptions), true, true, NULL)
#9 /usr/local/apache/common-local/php-1.21wmf7/includes/EditPage.php(2987): WikitextContent->getParserOutput(Object(Title), NULL, Object(ParserOptions))
#10 /usr/local/apache/common-local/php-1.21wmf7/includes/EditPage.php(2013): EditPage->getPreviewText()
#11 /usr/local/apache/common-local/php-1.21wmf7/includes/EditPage.php(421): EditPage->showEditForm()
#12 /usr/local/apache/common-local/php-1.21wmf7/includes/actions/EditAction.php(51): EditPage->edit()
#13 /usr/local/apache/common-local/php-1.21wmf7/includes/actions/EditAction.php(71): EditAction->show()
#14 /usr/local/apache/common-local/php-1.21wmf7/includes/Wiki.php(429): SubmitAction->show()
#15 /usr/local/apache/common-local/php-1.21wmf7/includes/Wiki.php(305): MediaWiki->performAction(Object(Article), Object(Title))
#16 /usr/local/apache/common-local/php-1.21wmf7/includes/Wiki.php(555): MediaWiki->performRequest()
#17 /usr/local/apache/common-local/php-1.21wmf7/includes/Wiki.php(448): MediaWiki->main()
#18 /usr/local/apache/common-local/php-1.21wmf7/index.php(59): MediaWiki->run()
#19 /usr/local/apache/common-local/live-1.5/index.php(3): require('/usr/local/apac...')
#20 {main}

Reedy added a comment.Jan 14 2013, 6:16 PM

Looks to be 4997 in master:

if(!preg_match( "/^($prots)$chars+$/u", $link)){
$localLinkTitle = Title::newFromText($link);
$link = $localLinkTitle->getLocalURL();
}

newFromText() can return null

IAlex added a comment.Jan 14 2013, 9:11 PM

Fix pending in Gerrit change 43885.

(In reply to comment #3)

Fix pending in Gerrit change #43885.

Merged by Aaron Schulz on the 24th.