Page MenuHomePhabricator

Translation notifications should always be delivered via Translation Notification Bot, including at Meta
Closed, ResolvedPublic

Description

I do not know which criteria uses the extension to choose one or another account but when a translation notification is issued (at Meta, via the notifytranslators special page) some (most of them) are delivered by the personal account of the translation administrator who issued the command https://meta.wikimedia.org?diff=prev&oldid=5043916 while others are notified via the ad hoc account https://meta.wikimedia.org/wiki/Special:Contributions/Translation_Notification_Bot.

  • Notifications should be always sent by the TNBot no matter the project.
  • Edits on user talk pages by TNBot should not be marked as "minor" so it is possible for the projects to flag the account as bot, to avoid flooding/cluttering of recentchanges (which already happens now at Meta, each time a translation notification is issued, recentchanges becomes unusable) & possibilitating at the same time that the user receives the orange bar "you have new messages" (since only bots have the 'nominornewtalk' right).

Thanks.


Version: unspecified
Severity: enhancement
URL: https://meta.wikimedia.org/wiki/Special:Contributions/Translation_Notification_Bot
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=41637
https://bugzilla.wikimedia.org/show_bug.cgi?id=39104

Details

Reference
bz44210

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:30 AM
bzimport set Reference to bz44210.
bzimport added a subscriber: Unknown Object (MLST).

Regarding third poing, see also bug 40839. Bug 41637 might be of general interest too.

(In reply to comment #0)

  • Notifications should be always sent by the TNBot no matter the project.
  • Edits on user talk pages by TNBot should not be marked as "minor" [...]

Note that the second is already the case, only the first had to be fixed.
I think this makes sense, however it may need to be a configuration setting or something else which allows the sysadmin not to have a specific account for the Translation Notification Bot, which might be undesirable for wikis which don't need cross-wiki notifications, especially until bug 39104 is fixed.

The current criteria is very simple: if user "talk page on another wiki", then it is delivered via a Bot.

Merged. Will be deployed some time soon.

The fix is probably broken, first such edit on wikidatawiki caused bug 47811.
https://www.wikidata.org/w/index.php?title=User_talk:Vogone&diff=prev&oldid=32364841

(In reply to comment #7)

The fix is probably broken, first such edit on wikidatawiki caused bug 47811.
https://www.wikidata.org/w/index.php?title=User_talk:
Vogone&diff=prev&oldid=32364841

Amir, any plan to fix it?

The issue with the fix is that it won't create the account if it doesn't exist yet.

A fix like what the AbuseFilter does (https://github.com/wikimedia/mediawiki-extensions-AbuseFilter/blob/master/AbuseFilter.class.php#L1624) should work.

(In reply to Kunal Mehta (Legoktm) from comment #9)

The issue with the fix is that it won't create the account if it doesn't
exist yet.
A fix like what the AbuseFilter does
(https://github.com/wikimedia/mediawiki-extensions-AbuseFilter/blob/master/
AbuseFilter.class.php#L1624) should work.

getFilterUser currently at https://github.com/wikimedia/mediawiki-extensions-AbuseFilter/blob/9a632d04ec0812d49d0761ce1cb20d154bf7760c/AbuseFilter.class.php#L1676

Change 140157 had a related patch set uploaded by Kunalgrover05:
Make new user if not present

https://gerrit.wikimedia.org/r/140157

Change 140157 merged by jenkins-bot:
Make new user if not present

https://gerrit.wikimedia.org/r/140157