Page MenuHomePhabricator

Add ability for section description of gadgets section
Closed, ResolvedPublicFeature

Description

Add ability for section description of gadgets section

The "General gadgets" text in https://test.wikipedia.org/w/index.php?title=MediaWiki:Gadgets-definition&oldid=155819 is not shown on Special:Preferences on Gadgets tab.


Version: unspecified
Severity: enhancement
URL: https://test.wikipedia.org/w/index.php?title=MediaWiki:Gadgets-definition&oldid=155819

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:32 AM
bzimport set Reference to bz44233.
bzimport added a subscriber: Unknown Object (MLST).
DannyS712 changed the subtype of this task from "Task" to "Feature Request".Feb 29 2020, 6:45 AM

Change #1109707 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/Gadgets@master] Add support for gadgets section descriptions

https://gerrit.wikimedia.org/r/1109707

Change #1109707 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Add support for gadgets section descriptions

https://gerrit.wikimedia.org/r/1109707

SD0001 claimed this task.

The message name ended up to be a bit confusing since gadget section headers use Gadget-section- convention but these new messages use Gadgets-section-info- convention. Personally I think this needs to be fixed before it gets too prevalent. (I tried creating the section description by going to header description from Special:Gadgets and adding -info- and that’s how I spotted the issue.) @SD0001 @Novem_Linguae, what do you think?

It seemed OK to me. Do you have a suggestion of what we should change it to?

My suggestion is that both should start either with Gadget- or Gadgets- (Gadget- being preferable due to being an older convention and not requiring much changes). Right now it seems unsynchronised between the two despite the messages being related (one is section header and another is section description).

Oh I think I see what you mean now. One starts with gadget- and the other starts with gadgets-.

(gadget-section-browsing)
(gadgets-section-info-browsing)

I'll write a patch to change the new one to start with gadget-, for consistency. Thanks for spotting.

Change #1144605 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/Gadgets@master] Hooks: change gadgets-section-info-$section to gadget-section-info-$section

https://gerrit.wikimedia.org/r/1144605

Gadgets-, with the s, was chosen to avoid conflicting with the description messages of gadgets (which start with Gadget-, without the s). In retrospect, agreed that being consistent with section name messages (which can already name-conflict anyway) makes more sense.

Change #1144605 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Hooks: change gadgets-section-info-$section to gadget-section-info-$section

https://gerrit.wikimedia.org/r/1144605