Page MenuHomePhabricator

Fatal error when accessing some variables on non-text content
Closed, ResolvedPublic


Accessing some variables like new_html or added_links, AbuseFilter will cause a fatal error for non-text content. This makes editing of such content impossible.

The problem is rooted in AFComputedVariable::compute(), which tries to parse text it believes to be wikitext. But for non-text content, this text may be something else entirely - typically, a plain mock of the actual page content, used for regex based filters.

The fatal error is always triggered when trying to view the log details for a filter action performed on a non-text page, since AbuseFilter will then try to evaluate all variables.

Version: unspecified
Severity: critical



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:33 AM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz44243.
bzimport added a subscriber: Unknown Object (MLST).

Is there a way to reproduce the fatal?

Closed older resolved bugs as verified.