Page MenuHomePhabricator

InstantCommons both downloads to server, *and* hotlinks Wikimedia Commons for full size
Closed, ResolvedPublic

Description

If you include a full size image, like:

[[File:Lead electrolytic and 1cm3 cube.jpg]]

it downloads the whole thing, then hotlinks Wikimedia Commons anyway.


Version: 1.21.x
Severity: normal

Details

Reference
bz44295

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:36 AM
bzimport set Reference to bz44295.
bzimport added a subscriber: Unknown Object (MLST).

I tested this at http://piramido.wmflabs.org/wiki/Bug_44295.

"[[File:Lead electrolytic and 1cm3 cube.jpg]]" as input produces the following HTML output:


<a href="/wiki/File:Lead_electrolytic_and_1cm3_cube.jpg" class="image"><img alt="Lead electrolytic and 1cm3 cube.jpg" src="http://upload.wikimedia.org/wikipedia/commons/e/e6/Lead_electrolytic_and_1cm3_cube.jpg" width="5260" height="3341" /></a>

"[[File:Lead electrolytic and 1cm3 cube.jpg|10px]]" as input produces the following HTML output:


<a href="/wiki/File:Lead_electrolytic_and_1cm3_cube.jpg" class="image"><img alt="Lead electrolytic and 1cm3 cube.jpg" src="/srv/mediawiki/images/thumb/e/e6/Lead_electrolytic_and_1cm3_cube.jpg/10px-Lead_electrolytic_and_1cm3_cube.jpg" width="10" height="6" srcset="/srv/mediawiki/images/thumb/e/e6/Lead_electrolytic_and_1cm3_cube.jpg/15px-Lead_electrolytic_and_1cm3_cube.jpg 1.5x, /srv/mediawiki/images/thumb/e/e6/Lead_electrolytic_and_1cm3_cube.jpg/20px-Lead_electrolytic_and_1cm3_cube.jpg 2x" /></a>

When I tested it was the worst of both worlds:

it downloads the whole thing, then hotlinks Wikimedia Commons anyway.

Mattflaschen-WMF renamed this task from InstantCommons hotlinks Wikimedia Commons for full size to InstantCommons both downloads to server, *and* hotlinks Wikimedia Commons for full size.Dec 16 2015, 10:25 PM
Mattflaschen-WMF set Security to None.
Nemo_bis claimed this task.

Thanks for clarifying. I can't reproduce with current InstantCommons configuration, I think this is fixed.