Page MenuHomePhabricator

PageTriage extension incorrectly inserting deletion rationale into "miscellany for deletion" (MFD) tag
Closed, ResolvedPublic

Description

See http://en.wikipedia.org/w/index.php?title=User:William_Esdale&oldid=535131715 - it's putting the nomination in space of the page name rather than creating a nomination page in which it inserts the nomination.


Version: unspecified
Severity: normal

Details

Reference
bz44426

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:17 AM
bzimport added a project: PageCuration.
bzimport set Reference to bz44426.

Andre, if you're going to de-prioritise a bug can you please leave a note explaining why, in the future? This is a bug that prevents a fundamental workflow in an actively maintained extension from working.

I think this is a problem with the mfd template?

The MFD page looks correct: http://en.wikipedia.org/wiki/Wikipedia:Miscellany_for_deletion/User:William_Esdale

and the tag on the page looks correct too {{mfd|foo}}.

So yeah, I think it's the template.

(In reply to comment #1)

Andre, if you're going to de-prioritise a bug can you please leave a note
explaining why, in the future?

Oliver: I didn't deprioritise - the report had no priority setting at all, so I set an initial one. Developers (and any other parties that have a deeper understanding of this field) are highly welcome and encouraged to correct my first impression, or to set a priority themselves when reporting.

(In reply to comment #3)

The MFD page looks correct:
http://en.wikipedia.org/wiki/Wikipedia:Miscellany_for_deletion/User:
William_Esdale

and the tag on the page looks correct too {{mfd|foo}}.

So yeah, I think it's the template.

The template hasn't been altered since 2010 :/

(In reply to comment #4)

(In reply to comment #1)

Andre, if you're going to de-prioritise a bug can you please leave a note
explaining why, in the future?

Oliver: I didn't deprioritise - the report had no priority setting at all,
so I
set an initial one. Developers (and any other parties that have a deeper
understanding of this field) are highly welcome and encouraged to correct my
first impression, or to set a priority themselves when reporting.

Gotcha; my apologies.

Unable to reproduce on personal wiki (lots of templates and log pages needed),
no permissions to review on en.wiki

Is there a way to test this on test.wiki, get the permissions for same?

(In reply to comment #0)

See
http://en.wikipedia.org/w/index.php?title=User:William_Esdale&oldid=535131715 -
it's putting the nomination in space of the page name rather than creating a
nomination page in which it inserts the nomination.

It looks the nomination page was properly created (cf. https://en.wikipedia.org/w/index.php?title=Wikipedia:Miscellany_for_deletion/User:William_Esdale&action=history).

The bug here seems to be that instead of {{mfd|rationale}}, the extension should have inserted {{mfd}}. The local template seems to be completely irrelevant here.

Unable to reproduce as before but I think https://gerrit.wikimedia.org/r/#/c/47069/ is the fix.

Would appreciate if someone could verify.