Page MenuHomePhabricator

phpcs-HEAD should skip if there is no file to process
Closed, ResolvedPublic


"You must supply at least one file or directory to process"

Version: unspecified
Severity: major



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:27 AM
bzimport set Reference to bz44567.

Not a Git/Gerrit bug, rather an issue with Jenkins. Moved to Testing Infrastructure.

phpcs fails on JS-only changes , which is due to it being passed an empty fileset.

Assigning to myself, I need to tweak out the phpcs-HEAD macro or just skip the entire build whenever there is no PHP files altered.

  • Bug 44778 has been marked as a duplicate of this bug. ***
  • Bug 44842 has been marked as a duplicate of this bug. ***

According to my tests, the change above fixed the issue.

I have launched a reconfiguration of all phpcs-HEAD jobs.

We turned the original blacklisting of css/js to a whitelist of php/php5/inc/sample with change