Page MenuHomePhabricator
Create Task
Maniphest T46718

AbortNewAccount hook was changed accidentially in I402c6beb
Closed, ResolvedPublic
Actions

Description

In the past, hooks can set an HTML error message via the second argument $abortError. After I402c6beb, the message is treated as wikitext and parsed (again), causing HTML tags which are unacceptable in wikitext shown on pages, where old extensions like TitleBlacklist parse error messages themselves and send HTML output as $abortError.

Version: 1.21.x
Severity: normal
URL: https://gerrit.wikimedia.org/r/17952
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52191
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

Details

Reference
bz44718

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
Resolved• SpageT54191 Badly formatted login error when username banned from creation
ResolvedParent5446T46718 AbortNewAccount hook was changed accidentially in I402c6beb
· · ·

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:37 AM
• bzimport added projects: MediaWiki-User-login-and-signup, good first task.
• bzimport set Reference to bz44718.
liangent created this task.Feb 6 2013, 4:26 PM
Parent5446 added a comment.Feb 6 2013, 9:27 PM

Sorry about that. That's my fault. The reason is that even though the HTML is being wrapped in a RawMessage, I forgot that it was being parsed when it got returned to the parent function. I'll have a quick patch fix shortly.

Parent5446 added a comment.Feb 7 2013, 12:44 AM

This is a temporary fix. I will make a more robust fix when I construct a better way for messages to be stored within messages and for statuses to handle message parameters.

https://gerrit.wikimedia.org/r/47821

Aklapper added a comment.May 16 2013, 4:07 PM

(In reply to comment #2 by Tyler Romeo)

This is a temporary fix.
https://gerrit.wikimedia.org/r/47821

Patch in Gerrit still awaiting review & merge. :-/

gerritbot added a comment.Jun 30 2013, 8:47 PM

Change 47821 had a related patch set uploaded by Matmarex:
Fix double-parsing of account creation messages.

https://gerrit.wikimedia.org/r/47821

Parent5446 added a comment.Aug 2 2013, 6:45 PM
  • Bug 38894 has been marked as a duplicate of this bug. ***
liangent added a comment.Sep 20 2013, 12:28 PM
  • Bug 54336 has been marked as a duplicate of this bug. ***
gerritbot added a comment.Oct 24 2013, 10:35 AM

Change 47821 merged by jenkins-bot:
Fix double-parsing of account creation messages.

https://gerrit.wikimedia.org/r/47821

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL