Page MenuHomePhabricator

In edit preview, show categories in their standard position relative to the parsed page
Open, LowPublic

Description

Author: puzzlet

Description:
When editing a page, I'm not sure about the names of category pages I would like
to add sometimes, so I press Alt+P(for Preview) to check, but I would find no
category links on the preview.


Version: unspecified
Severity: enhancement

Details

Reference
bz2679

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 8:38 PM
bzimport set Reference to bz2679.

In MonoBook they show at the bottom of the page, below the edit box.

puzzlet wrote:

Well, I have never realized the category links placed below the edit box!
I think showing category links above the edit box would be more reasonable.

Since its original introduction, category display is part of the skin. Some skins put them at the top (the old Standard skin, Cologne Blue), others put them at the bottom (MonoBook).

This ends up looking weird in edits previews, since the category links are still shown by the skin for the whole page, and can be separated from the preview part of the page by the edit box.

This is kind of silly. :)

Probably we should retool it so the category links are shown sensibly near the page text, which would be predictable in the case of previews.

I'll be bold and WONTFIX this. Category display is part of a skin, and it's exactly the same during regular viewing as during editing/previewing.

Not to mention that there is a preference for showing the edit box above/below preview, which further complicates things.

(In reply to comment #4)

I'll be bold and WONTFIX this. Category display is part of a skin, and it's
exactly the same during regular viewing as during editing/previewing.

I didn't notice the category links during preview for years. This is a real user interface issue that should be addressed properly.

This is not limited to categories, then, as language links are previewed similarly, except they're even less visible, being placed in the sidebar instead of in the content. (The whole thing with langlinks in the sidebar is weird, but that's a topic for a different discussion.)

And, obviously, this would have to be solved on a per-skin basis.

Also, what kind of design do you suggest? What could be clearer than exactly the same behavior as during reading?

And where would we stuff them? Recent trend seems to be to de-clutter the edit form itself, so it can't go around there. Above the preview? That would seem like "forcing" the categories on the user, and I'd say they are changed comparably rarely – and it could also suggest that the edit, unrelated to categories, did something unintended, as they would not be shown there during reading. Down below? Well, that's where they are now (on most of the skins) – maybe above the templates list would be better, I don't know – but then there's also the hidden categories list, which is rendered differently for people who have them hidden during reading (the default). Maybe to the side? Nah, just kidding.

(In reply to comment #6)

Also, what kind of design do you suggest? What could be clearer than exactly
the same behavior as during reading?

Above the textarea, of course. :-)

When you click edit and then click preview, you currently have something like this:


[page title]

[content]

[textarea]

[category links]

Instead, it should be something like this:


[page title]

[content]

[category links]

[textarea]

This way, when a user is scrolling down through the page, they can see the category links above the textarea with all of the other content.

-easy: there are still design doubts so it's not.

(In reply to comment #8)

-easy: there are still design doubts so it's not.

No there aren't. Restoring the keyword. Also, stop assuming that because a bug is marked as easy that it requires no thought. This is a stupid assumption.

Seems like this bug could be solved within function displayPreviewArea in /includes/EditPage.php. Unfortunatelly I do not know how to print out the cats within this function...

Jan submitted Gerrit change 47212 for fixing this.

I am stuck with the patch half way through... the category links were added above the edit box but I can not get rid of them from below the box... any hint appreciated.

I figured out what I needed (how to hide the links below box on preview). But I see the bug has multiple possible solutions. So I ask - do we want to strip the categories from the skins completely and make them show BELOW the article on all skins by default? Some skins show category links at the top of page - do we want to keep them doing that even on preview page or not?

I finally decided to only go with the Vector skin. A new patch set was submitted for review implementing this particular solution.

Change 47212 had a related patch set uploaded by Nemo bis:
(bug 2679) Adding category links above the edit box

https://gerrit.wikimedia.org/r/47212

I don't understand, how does this work with the preference to have the preview before or after the edit box? Because if one wants it after, categories at top would just be clutter.

(In reply to comment #16)

I don't understand, how does this work with the preference to have the
preview before or after the edit box? Because if one wants it after,
categories at top would just be clutter.

As I understand it, a more accurate bug summary might be "always couple category links with the page content." Currently, the text input area can interrupt the page content and the categories (as described in comment 7) when previewing a page. This should be fixed in Monobook and in any other core skins where it's an issue.

Thanks for cross-reference Gerrit change 47212. :-)

shreeshikha21 wrote:

I am new to FOSS and mediawiki how do I start on this bug and how do I replicate the error on my local machine.

This feature request already has a patch pending review.

... and the patch has been stalled for a year now...

Meanwhile, VisualEditor is on its mission to take over mainstream MediaWiki editing. Interestingly, categories are also out of sight when editing with VE. I wonder whether a request to have them visible already exists.

PS: looking at the long history of this task, it doesn't look that good first task...

Nemo_bis renamed this task from Show category links above the edit box to In edit preview, show categories in their standard position relative to the parsed page.Jan 4 2015, 7:07 PM
Nemo_bis set Security to None.

@Kozuch, it would be great if you could upload a new version of https://gerrit.wikimedia.org/r/#/c/47212/ that makes happy Jenkins at least...

@Qgil: sorry, I am out of time unfortunately... I will be happy for anyone else participating here...

@Kozuch, we all have busy times, no worries. However, do you plan to come back to this task at some point? I'm asking because the task is still assigned to you.

@Kozuch: This issue has been assigned to you a while ago.
Could you please provide a status update and inform us whether you are still working (or still plan to work) on this issue?
Only in case you do not plan to work on this issue anymore, should you be removed as assignee (via 'Reassign / Claim' in the 'Action' dropdown )? Thanks!

@Kozuch: I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!).
Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task.
Please claim this task again when you plan to work on it (via Add Action...Assign / Claim in the dropdown menu) - it would be welcome! Thanks for your understanding!

This is now 16 years old and still nasty.

The default skin (for IPs) is vector and at least this skin should show categories above the edit field.