Page MenuHomePhabricator

Allow to set limits on global blocks on IP ranges
Open, HighPublic

Description

GlobalBlocking right now is hardcoded to not allow anything higher than /16, and has no limits for IPv6. It should use $wgBlockCIDRLimit instead.

Details

Reference
bz44836

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:16 AM
bzimport added projects: GlobalBlocking, IPv6.
bzimport set Reference to bz44836.
bzimport added a subscriber: Unknown Object (MLST).
Legoktm created this task.Feb 10 2013, 1:46 AM

I would prefer, for the purposes of flexibility, for the two to be separate configuration variables so we have, say, a $wgGlobalBlockCIDRLimit.

Change 202776 had a related patch set uploaded (by Glaisher):
Allow to set a limit on global blocks on IP ranges

https://gerrit.wikimedia.org/r/202776

Glaisher renamed this task from Globalblocking should use $wgBlockCIDRLimit to Allow to set limits on global blocks on IP ranges.Apr 8 2015, 5:20 PM
Glaisher claimed this task.
Glaisher removed a project: IPv6.
Glaisher set Security to None.
Glaisher removed a subscriber: gerritbot.
Glaisher removed a project: IPv6.Apr 8 2015, 5:21 PM

Change 202776 abandoned by Glaisher:
Allow to set a limit on global blocks on IP ranges

Reason:
Per my comment earlier - needs extra work.

https://gerrit.wikimedia.org/r/202776

Glaisher raised the priority of this task from Normal to High.Oct 24 2015, 7:38 AM
Glaisher removed a project: Patch-For-Review.
Tgr added a subscriber: Tgr.Dec 7 2016, 5:17 AM

From https://gerrit.wikimedia.org/r/#/c/321429/:

To allow for message reuse, this mostly copies the CIDR-handling logic
from ApiQueryBlocks into ApiQueryGlobalBlocks, which has the side effect
of making it actually work for IPv6. Too much refactoring of the rest of
the code would be needed to properly solve T46836 for me to do right
now, though.

Jdforrester-WMF removed hoo as the assignee of this task.Feb 9 2017, 12:39 AM