Page MenuHomePhabricator

WebVideoTranscodeJob can return Status instead of bool
Closed, ResolvedPublic


At a certain point in WebVideoTranscodeJob::run() $status changes from a bool to a Status object, and is then returned. The return value of Job::run() is expected to be a status, and if it's otherwise, that may lead to issues.

Since Gerrit 48860, any non-boolean result is interpreted as true, which makes the issues less severe, but this should nevertheless be fixed.

Version: master
Severity: normal
See Also:



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:25 AM
bzimport set Reference to bz44963.

jgerber wrote:

looking at the docs Job::run() should only return a boolean not a status. makes sure only boolean is returned.

Gilles triaged this task as Unbreak Now! priority.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Needs Triage.Dec 4 2014, 11:22 AM