Page MenuHomePhabricator

[Task] Clean up Claims::getDiff()
Closed, InvalidPublic

Description

Claims::getDiff() currently uses an elaborate hack to compare the lists of claims by claim hash; This should be done using ListDiffer::setComparisonCallback() instead.

Details

Reference
bz44967

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:25 AM
bzimport set Reference to bz44967.
bzimport added a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
JanZerebecki renamed this task from Clean up Claims::getDiff() to [Task] Clean up Claims::getDiff().Sep 10 2015, 1:52 PM
JanZerebecki updated the task description. (Show Details)
JanZerebecki added a project: Technical-Debt.
JanZerebecki set Security to None.
JanZerebecki removed a subscriber: Wikidata-bugs.

How does this need to be tested?

Addshore subscribed.

This class and method no longer exist
And I guess the replacement is StatementList, which also has no diff method