Page MenuHomePhabricator
Create Task
Maniphest T47072

JobQueueGroup::getQueuesWithJobs used one query per type
Closed, ResolvedPublic
Actions

Description

Looking at the log gives many queries against the job table to determine, if some jobs exist there. The calls are out of JobQueueGroup::getQueuesWithJobs or JobQueueGroup::getDefaultQueuesWithJobs to JobQueue::isEmpty

Maybe this can be optimized by using a DISTINCT query? That sounds faster, than, by default, 9 queries.

Version: 1.21.x
Severity: normal

Details

Reference
bz45072

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:33 AM
• bzimport added projects: MediaWiki-Core-JobQueue, Performance Issue.
• bzimport set Reference to bz45072.
• bzimport added a subscriber: Unknown Object (MLST).
duplicatebug created this task.Feb 16 2013, 11:07 AM
gerritbot added a comment.Jul 4 2013, 7:26 AM

Change 71966 had a related patch set uploaded by Aaron Schulz:
jobqueue: improved performance of JobQueueGroup::getQueuesWithJobs()

https://gerrit.wikimedia.org/r/71966

gerritbot added a comment.Oct 1 2013, 3:23 AM

Change 71966 merged by jenkins-bot:
jobqueue: improved performance of JobQueueGroup::getQueuesWithJobs()

https://gerrit.wikimedia.org/r/71966

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits