Page MenuHomePhabricator

protection bubbles tell you you're blocked
Closed, ResolvedPublic

Description

Author: pinkampersand.wikimedia

Description:
When you try to edit an item that's been protected, you still see the "edit"/"add" buttons and have the ability to type in the text fields. While the "save" button is initially greyed out, once you start typing, it turns blue again. It's only when you try to save the change that you get the message saying the page has been protected. Seems to me it would be better to have all of the buttons just not appear, like when you're viewing an old revision, and to have the notice about the page being protected pop up in a bubble, like the one that tells you if you're editing logged out.


Version: unspecified
Severity: normal

Details

Reference
bz45140

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:37 AM
bzimport set Reference to bz45140.
bzimport added a subscriber: Unknown Object (MLST).

What kind of browser do you use? Is it possible to edit only parts of the page? Is the text boxes grayed out?

pinkampersand.wikimedia wrote:

(In reply to comment #1)

What kind of browser do you use?

I use Google Chrome, version 23.0.1271.111, on an Alex series Chromebook.

Is it possible to edit only parts of the
page?
Is the text boxes grayed out?

Well... strangely enough, when I went to check your question, I found that the buttons were in fact all greyed out. Maybe something changed in all the updates yesterday? It's much better right now. I'd mark this as resolved, but, while we're on the topic, I notice that the text says "You are blocked from editing", when it should say that the page is protected. Try editing https://www.wikidata.org/wiki/Q16 from a non-admin account to see what I mean. (Or https://www.wikidata.org/wiki/Q5296 while logged out.)

Yes, its about the same I found and I think there is a merged changeset that made the links stay disabled.

The blocked message is a bug and should be fixed.

pinkampersand.wikimedia wrote:

Just pinging to see where we are on this. All that needs to be changed is for a new message to show up on the tooltip instead of [[d:MediaWiki:Wikibase-blockeduser-tooltip-message]].

  • Bug 46169 has been marked as a duplicate of this bug. ***

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git;a=commitdiff;h=384baeac31516857131553b80a5813b79588953f;hp=ac63d423b3f0fc133e5ad99a57479a561a7a30ee

The code in this commit seems to wrongly assume that the only time blockItemActions is called would be when the user is blocked, but it also seems that this is also called when the page is protected.

Restricted Application added a subscriber: StudiesWorld. · View Herald Transcript