Page MenuHomePhabricator

"Preview" shown in title bar for action=submit on special pages (Watchlist)
Closed, ResolvedPublic


Author: ral315

When removing items from watchlist, page title shows "My watchlist -
PREVIEW...", even though the items have already been removed (therefore, it's
not a preview). Just something I thought I'd point out.

Version: unspecified
Severity: trivial



Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 8:38 PM
bzimport set Reference to bz2735.
bzimport added a subscriber: Unknown Object (MLST).

jyri-petteri.paloposki wrote:

An diff proposal to fix the bug

Submitting an diff proposal to fix the bug.


ais523 wrote:

(adding keywords, a patch is present and needs review)

  • Bug 10403 has been marked as a duplicate of this bug. ***

robchur wrote:

Possible cleaner fix

One possible method that's cleaner than just excluding on namespace; ditch the special-case checking per action in Title::setPageTitle() and have actions which want specific extras in the HTML title set these.


robchur wrote:

Tim fixed this in r24313 using a similar method.

epriestley added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:15 AM