Page MenuHomePhabricator

The <Centralauth-error-locked> message sucks and needs improvement
Open, MediumPublic

Description

The <Centralauth-error-locked> message sucks and needs improvement - it currently reads:

You cannot edit because your account is locked.

This compares poorly to <Globalblocking-blocked> in terms of giving users somewhere to go:

Your IP address $5 has been blocked on all wikis by $1 ($2). The reason given was "$3". The block $4.

(This is being changed right now anyway.)


Version: unspecified
Severity: normal
See Also:
T59866: Causes "Incorrect password entered" error when the account is globally locked
T62607: Add lock reason (from log) or [[Special:CentralAuth/$1]] ($1=username) link to 'centralauth-login-error-locked' message.

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:29 AM
bzimport set Reference to bz45469.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

The <Centralauth-error-locked> message sucks and needs improvement - it
currently reads:

You cannot edit because your account is locked.

This compares poorly to <Globalblocking-blocked> in terms of giving users
somewhere to go:

Your IP address $5 has been blocked on all wikis by $1 ($2). The reason

given
was "$3". The block $4.

(This is being changed right now anyway.)

Does the extension even give an error when logging in? I think it's just the incorrect passwd message.

James: should this bug continue to be assigned to you?

(In reply to comment #2)

James: should this bug continue to be assigned to you?

Bump.

And did https://gerrit.wikimedia.org/r/98568 fix this bug? Can someone check?

(In reply to MZMcBride from comment #3)

(In reply to comment #2)

James: should this bug continue to be assigned to you?

Bump.

And did https://gerrit.wikimedia.org/r/98568 fix this bug? Can someone
check?

This bug is about Centralauth-error-locked, not Centralauth-login-error-locked. Also, that did not include any detailed info like the reason for being locked.

(In reply to James Forrester from comment #0)
Are you still working on this?

(In reply to PiRSquared17 from comment #4)

This bug is about Centralauth-error-locked, not
Centralauth-login-error-locked. Also, that did not include any detailed
info like the reason for being locked.

Can you submit a patch please?

(In reply to Nemo from comment #6)

(In reply to PiRSquared17 from comment #4)

This bug is about Centralauth-error-locked, not
Centralauth-login-error-locked. Also, that did not include any detailed
info like the reason for being locked.

Can you submit a patch please?

This is nontrivial, like bug 61548. The lock reasons are not stored in a central location currently. Using the current scheme, we would need to query every wiki (since locks can be from any wiki). Perhaps it would be better to create a central location for the globalauth logs or at least the current locks (maybe in globaluser table?).

James, are you still interested in this?

There is a bug about restricting changes of global groups rights and membership to the central wiki; there is probably also one for locks. If that's a requirement for this bug, let's add it to blockers and get all of them done at once.

A temporary fix would be to only look on the "central wiki", and just give the current message if it's not found there.

(In reply to Nemo from comment #8)

There is a bug about restricting changes of global groups rights and
membership to the central wiki; there is probably also one for locks. If
that's a requirement for this bug, let's add it to blockers and get all of
them done at once.

Ticket link?

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2015, 4:58 PM
jrbs added a subscriber: jrbs.

Not a matter of tone but of availability of correct details to the local wiki.

Nemo_bis set Security to None.
Restricted Application added a subscriber: JEumerus. · View Herald TranscriptApr 18 2016, 9:18 AM

Change 413248 had a related patch set uploaded (by Gerrit Patch Uploader; owner: Gerrit Patch Uploader):
[mediawiki/extensions/WikimediaMessages@master] Locally override Centralauth-error-locked

https://gerrit.wikimedia.org/r/413248

This comment was removed by Bugreporter.

Change 413248 abandoned by MarcoAurelio:
[mediawiki/extensions/WikimediaMessages@master] Locally override Centralauth-error-locked

Reason:
No longer required.

https://gerrit.wikimedia.org/r/413248

Change 413248 restored by MarcoAurelio:
[mediawiki/extensions/WikimediaMessages@master] Locally override Centralauth-error-locked

https://gerrit.wikimedia.org/r/413248