Keyboard Icon of Language selector for RTL languages should be at left
Closed, ResolvedPublic

Description

Keyboard Icon of Language selector for RTL langugaes should at left now it is at right so i covers the first part of text! and we should disable it.


Version: unspecified
Severity: normal
Whiteboard: ux

bzimport set Reference to bz45585.
Yamaha5 created this task.Via LegacyFeb 28 2013, 9:38 PM
Yamaha5 added a comment.Via ConduitFeb 28 2013, 9:43 PM

Excuse me for bad typing it is saved at the middle of typing!

bug:

Keyboard Icon of Language selector for RTL languages should be at the left of input-text now it is at the right so the icon covers the first part of input-text and we should disable it.

Yamaha5 added a comment.Via ConduitMar 1 2013, 11:32 AM

Created attachment 11867
Icon should be at left

Attached:

Yamaha5 added a comment.Via ConduitMar 1 2013, 4:27 PM

I think in http://bits.wikimedia.org/static-1.21wmf10/extensions/UniversalLanguageSelector/lib/jquery.ime/jquery.ime.js

under line

position: function () {

it should define of the language is RTL the position should be left

left = position.left + this.$element.outerWidth() - this.$imeSetting.outerWidth();
if (this.$element.css('direction') === 'rtl') {
left = position.right + this.$element.outerWidth() - this.$imeSetting.outerWidth();
}

Aklapper added a comment.Via ConduitMar 1 2013, 9:59 PM

[RTL problem => blocking bug 745]

gerritbot added a comment.Via ConduitMay 1 2013, 6:39 AM

Related URL: https://gerrit.wikimedia.org/r/61749 (Gerrit Change If3ee213daae8cd8e5cefb6daecd19eb3a6da76c9)

Nikerabbit added a comment.Via ConduitMay 5 2013, 9:27 AM

Amir: could you make patch to update our libs from upstream?

Amire80 added a comment.Via ConduitJun 11 2013, 1:13 AM

Fixed by Moriel.

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.