Keyboard Icon of Language selector for RTL languages should be at left
Closed, ResolvedPublic

Description

Keyboard Icon of Language selector for RTL langugaes should at left now it is at right so i covers the first part of text! and we should disable it.


Version: unspecified
Severity: normal
Whiteboard: ux

Details

Yamaha5 created this task.Feb 28 2013, 9:38 PM

Excuse me for bad typing it is saved at the middle of typing!

bug:

Keyboard Icon of Language selector for RTL languages should be at the left of input-text now it is at the right so the icon covers the first part of input-text and we should disable it.

Created attachment 11867
Icon should be at left

Attached:

I think in http://bits.wikimedia.org/static-1.21wmf10/extensions/UniversalLanguageSelector/lib/jquery.ime/jquery.ime.js

under line

position: function () {

it should define of the language is RTL the position should be left

left = position.left + this.$element.outerWidth() - this.$imeSetting.outerWidth();
if (this.$element.css('direction') === 'rtl') {
left = position.right + this.$element.outerWidth() - this.$imeSetting.outerWidth();
}

[RTL problem => blocking bug 745]

Related URL: https://gerrit.wikimedia.org/r/61749 (Gerrit Change If3ee213daae8cd8e5cefb6daecd19eb3a6da76c9)

Amir: could you make patch to update our libs from upstream?

Fixed by Moriel.

Add Comment