Page MenuHomePhabricator

Google Maps not working with https
Closed, ResolvedPublic

Details

Reference
bz45697

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:17 AM
bzimport set Reference to bz45697.

Does this also mean that bug 44224 comment 2 would not help? (Maps have been broken for a couple months now on translatewiki.net.)

If you allow saving via both http and https, then the saved content will have the link for the protocol with which it was saved. Known issue, some bug exists for this already.

Where is the code? Is it enough to just make sure that protocol relative url is saved?

Looks like it is in MapsGoogleMaps3::getApiScript.

Do protocol relative URLs work in older browsers?

All major browsers do support them. I'm unable to find definite resources on this, but MediaWiki uses protocol relative urls a lot without any reported issues that I am aware of.

Relevant quip:
[Relative URIs] They're not not recommended, it just says their usage is rare. Which is a statement that was true in '05, and which we made false in '11. –RoanKattouw

Well, by any means go ahead and change it then.

Funny that after changing that it now says "Your browser is not compatible with Google Maps v3." even though I'm using the latest Chrome.

Funny that after changing that it now says "Your browser is not compatible with
Google Maps v3." even though I'm using the latest Chrome.

That will happen when the Google Maps API code does not get loaded. Is this the case after your changes? Seems to work fine for me, in both ff and chromium.

(In reply to comment #9 by Niklas Laxström)

https://gerrit.wikimedia.org/r/52220

Merged three months ago. Is this bug report FIXED or is there more to do?

(In reply to comment #11)

Merged three months ago. Is this bug report FIXED or is there more to do?

The URL works correctly, with everything loaded securely from googleapis.com and no errors in dev tools, as of Chromium 25.0. I've not seen problems with our maps in the last weeks/months, so I think this can be closed.