Page MenuHomePhabricator

API module wbremoveclaims fail to apply baserevid
Closed, DeclinedPublic

Description

In API module wbremoveclaims a line is lost and the params is not pulled in and used during load, which would later create problems during save as conflicts will be handled in some weird way.


Version: unspecified
Severity: major

Details

Reference
bz45761

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:21 AM
bzimport set Reference to bz45761.
bzimport added a subscriber: Unknown Object (MLST).
jeblad created this task.Mar 6 2013, 1:22 AM
daniel added a comment.Mar 6 2013, 3:52 PM

The above fix has serious logic problems (not caused by the fix itself, but preventing the fix from working in some cases). We may need to revert it. Reopening until this has been re-examined.

daniel added a comment.Mar 6 2013, 3:59 PM

The current fix will cause the request to Fail with an Error if a base revision ID is supplied and the mentioned Statements belong to two different items (because the base revision will not be correct for at least one of them).

If we allow a list of statements from different items, we need to accept a list of base revisions. Better to restrict this module to statements on a single item.

jeblad added a comment.Mar 7 2013, 1:50 PM

A request removing statements from two different items would be erroneous call in my opinion, and then the correct behavior would be to fail. I think the module should have a restriction on the ids it can accept.

This is although another bug.

daniel added a comment.Mar 7 2013, 3:18 PM

(In reply to comment #4)

A request removing statements from two different items would be erroneous
call
in my opinion, and then the correct behavior would be to fail. I think the
module should have a restriction on the ids it can accept.

Yes, that would also greatly simply the code.

This is although another bug.

Yes, but this bug should perhaps depend on that other bug.

seems to be ok now