Page MenuHomePhabricator

behavior changed: GettingStarted shows "Looking for more to do" upon null edit
Closed, ResolvedPublic

Description

Before Mar 4, making a "null edit" (opening the editor and saving the page but making no changes) in the course of a tour like http://test2.wikipedia.org/wiki/Bottle?tour=gettingstarted by design did not show the "Looking for more to do" prompt.

As of Mar 5, making a "null edit" in the course of the tour produces the "Looking for more to do" prompt.

If this change in behavior is intended, please close the bug to let me know. It is causing an automated browser test to fail in all browsers.


Version: 1.21.x
Severity: normal

Details

Reference
bz45781

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:22 AM
bzimport set Reference to bz45781.

This is probably due to a false positive bug in our core implementation of the wgPostEdit boolean.

swalling wrote:

Hmm. Yeah on English Wikipedia just yesterday I got the correct behavior (no final tour step if edit is null).

We'll be disabling this particular tour tomorrow, so we will have time to figure out the interaction between the core implementation of wgPostEdit and the tour at our leisure later.

Thanks for reporting Chris.

The PostEdit extension did not set wgPostEdit true for null edits.

I've submitted a Gerrit change to core, awaiting review:

https://gerrit.wikimedia.org/r/#/c/52459/

I considered changing the behavior of didSave too, but didn't for backwards compatibility.

Merged. The first WMF deployment branch with this fix will be 1.21wmf12.

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptJan 28 2016, 6:00 PM