Page MenuHomePhabricator

Extension ImageLink.php needs amendment for >= 1.5beta3 version
Closed, ResolvedPublic

Description

The extension implements free links (internal or external) over (internal)
images <imagelink>internalimage.png | internallink_or_externallink | alt
text</imagelink>

Due to a change in constant definition URL_PROTOCOLS [2] on 20050708, the small
extension [1] needs amendement

patch
if( preg_match( '/^(' . URL_PROTOCOLS . '):/', $linkTarget ) ) {

to
if( preg_match( '/^(' . URL_PROTOCOLS . ')/', $linkTarget ) ) {

i.e. delete the ":"

[1] http://leuksman.com/extensions/ImageLink.phps
[2]
http://cvs.defau.lt/cvsweb.cgi/phase3/includes/Parser.php.diff?r1=1.474&r2=1.475&f=h


Version: unspecified
Severity: normal

Details

Reference
bz2784

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:40 PM
bzimport set Reference to bz2784.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 690
proposed extension (file as extension/ImageLink.php )

Attached:

ImageLink isn't included in our CVS, and I've made a similar change to the code on my
private wiki, so considering this FIXED.