Page MenuHomePhabricator

ReferencedEntitiesFinder::findClaimLinks does not find items used in Snaks with deleted property with data type item
Closed, ResolvedPublic

Description

This is a bug in the handling of deleted properties in the UI. If the property was of type "item", the UI will also show the referenced item as "Deleted item" also if it still exists. The correct behavior would be to just show the property as "Deleted property" and show the label of the referenced item as usual.


Version: unspecified
Severity: normal

Details

Reference
bz45904

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:31 AM
bzimport set Reference to bz45904.
bzimport added a subscriber: Unknown Object (MLST).
Danwe added a comment.Mar 15 2013, 1:40 PM

Try this in your JS console:

$.evalJSON( mw.config.get( 'wbUsedEntities' ) )

This will not include the item used in the Snak using the deleted property. This is bad and a backend issue: The ReferencedEntitiesFinder::findClaimLinks does not (anymore?) find the item used in the Snak with the deleted property.
Also see EntityView::registerJsConfigVars, line 745:

$usedEntityIds = $refFinder->findClaimLinks( $entity->getClaims() );

Danwe added a comment.Mar 15 2013, 3:45 PM

See I3bb49eca1f20960a55cfdbd83599eb21d5d07903 for a fix.

Verified in Wikidata demo sprint 35-2

Restricted Application added a project: Wikidata. · View Herald TranscriptJan 28 2016, 6:00 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald Transcript