Page MenuHomePhabricator

Modernize protection log to use LogFormatter & have it decoupled from IRC text
Closed, ResolvedPublic

Description

See comments in Change-Id: Ifeec00fc98c7912b6e16b6f07d1fdc26ab4e4fb5

Currently protection log entries are stored in plain text which is also used as the IRC line, making it hard to be i18n'ed. It could be nice to just store the original restriction array, use the new LogFormatter architecture to format it on display, and have it decoupled from IRC text, so it can be correctly translated without breaking existing bots.

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:36 AM
bzimport set Reference to bz45988.
bzimport added a subscriber: Unknown Object (MLST).

Change 152156 had a related patch set uploaded (by Umherirrender):
Migrate protect log to new log system

https://gerrit.wikimedia.org/r/152156

Patch-For-Review

Change 152156 abandoned by Umherirrender:
Migrate protect log to new log system

Reason:
Old patch, no longer support from my side

Feel free to upload or modify in an own patch set.

https://gerrit.wikimedia.org/r/152156

Umherirrender removed a project: Patch-For-Review.
Umherirrender set Security to None.

Change 223440 had a related patch set uploaded (by Alex Monk):
Migrate move protect log to new log system

https://gerrit.wikimedia.org/r/223440

Change 223440 merged by jenkins-bot:
Migrate move protect log to new log system

https://gerrit.wikimedia.org/r/223440

Change 233166 had a related patch set uploaded (by Umherirrender):
[WIP] Migrate protect log to new log system

https://gerrit.wikimedia.org/r/233166

Change 233166 merged by jenkins-bot:
Migrate protect log to new log system

https://gerrit.wikimedia.org/r/233166

Umherirrender claimed this task.
Umherirrender removed a subscriber: wikibugs-l-list.
Glaisher subscribed.

Please mention this on Tech News as this has a quite visible change. With this change, timestamps are now shown in user's timezone, previously it was the actual UTC time at which the log was inserted.

Should probably be in release notes too?