Page MenuHomePhabricator

Use touchend instead of click event where possible
Closed, ResolvedPublic

Description

Author: jgonera

Description:
This will make the UI much more responsive.

We could also use the following library instead, but it's additional 8KB minified which seems a lot for such a simple thing:
http://labs.ft.com/articles/ft-fastclick/
https://github.com/ftlabs/fastclick


Version: unspecified
Severity: enhancement

Details

Reference
bz46012

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz46012.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Mar 12 2013, 1:52 AM

How much more responsive would this make the UI? Is there some way for us to get a feel of the difference?

The buttons on the settings page use touchend - notice how responsive these are in comparison to the hamburger button
en.m.wikipedia.org/wiki/Special:MobileOptions

jgonera wrote:

This is just the first step, it makes the UI more responsive only in a few places (but it's a start).

On iOS 4.3.2 the existing patch in alpha only seems to work if you bind to the document object rather than the window object. Very odd. Haven't found any reasoning to why..

This is currently in beta so marking as assigned.

Will be handled in next sprint

Change 164402 had a related patch set uploaded by Jdlrobson:
Push microtap to stable.

https://gerrit.wikimedia.org/r/164402

Change 164402 merged by jenkins-bot:
Push microtap to stable.

https://gerrit.wikimedia.org/r/164402