Page MenuHomePhabricator

Prompt the user to confirm a page change while an LQT edit form is open
Closed, ResolvedPublic

Description

.. and I can't press Back in the browser to get it back because LQT edit area is dynamically created with javascript.

Just lost another page, very annoying.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=46237
https://bugzilla.wikimedia.org/show_bug.cgi?id=46336
https://bugzilla.wikimedia.org/show_bug.cgi?id=49962
https://bugzilla.wikimedia.org/show_bug.cgi?id=53833

Details

Reference
bz46040

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:40 AM
bzimport set Reference to bz46040.
Krinkle created this task.Mar 12 2013, 8:15 PM

Isn't this rather a bug with the thing that creates a dialog "do you want to leave this page?"? (I don't know what component that is, I think it was introduced with Vector?)

Moving component to LiquidThreads. There are several issues like this in Lqt, see for example bug 46336 (I'm almost certain there's a much older report of the same issue).

(In reply to comment #1)

Isn't this rather a bug with the thing that creates a dialog "do you want to
leave this page?"? (I don't know what component that is, I think it was
introduced with Vector?)

This was part of the Vector extension, and is part of core now (merged per bug 46514). It could likely be expanded to be able to cover additional fields.

Related URL: https://gerrit.wikimedia.org/r/59159 (Gerrit Change I6234a7651f70034f8a17ad242ddcf5793f0b899d)

Change 59159 merged by jenkins-bot:
Prompt the user to confirm a page change while an LQT edit form is open

https://gerrit.wikimedia.org/r/59159

Approved by Nikerabbit.

Reopening: there is something wrong. The warning is displayed every time you leave a LQT-enabled page, even if you have just opened it and not touched anything.

Change 80803 had a related patch set uploaded by Alex Monk:
Fix for I6234a765

https://gerrit.wikimedia.org/r/80803

Change 80803 merged by jenkins-bot:
Fix for I6234a765

https://gerrit.wikimedia.org/r/80803

The same alert appears when editing a summary for a LQT-enabled page.
Could you reopen this bug?

Confirmed. :( I had tested editing the summary first but then forgot to retest. (You can edit status too now, btw.)

Change 82251 had a related patch set uploaded by Alex Monk:
Don't show edit form open warning when saving thread summary

https://gerrit.wikimedia.org/r/82251

Change 82251 merged by jenkins-bot:
Don't show edit form open warning when saving thread summary

https://gerrit.wikimedia.org/r/82251

Think this is now fixed, given Krenair's latest patch (thank you again!). Closing, provisionally.