Page MenuHomePhabricator

Do not format messages by direct formatting, wrap them in classed/id'ed element instead
Open, LowPublic

Description

Messages

scribunto-doc-page-does-not-exist

''Documentation for this module may be created at [[$1]]''

scribunto-doc-page-header

'''This is the documentation page for [[$1]]'''

contain direct formatting and are not wrapped in element with class/id thus are (easily) unstyleable.

Messages should contain plaintext as much as possible and be wrapped in element with class/id to be styleable. Please remove the formatting in messages and add the wrapping of them in the hook handling.


Version: unspecified
Severity: trivial
Whiteboard: usability

Details

Reference
bz46109

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz46109.
bzimport added a subscriber: Unknown Object (MLST).
Danny_B created this task.Mar 14 2013, 11:56 AM
Danny_B set Security to None.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2016, 6:58 AM
Devirk added a subscriber: Devirk.Jan 20 2016, 2:00 PM
Haritha28 added a subscriber: Haritha28.
Devirk removed a subscriber: Devirk.Jan 20 2016, 2:16 PM
Danny_B moved this task from Backlog to Doing on the good first bug board.Feb 18 2016, 3:34 PM
Haritha28 removed Haritha28 as the assignee of this task.Mar 4 2016, 5:10 PM
Danny_B moved this task from Doing to Backlog on the good first bug board.Mar 10 2016, 9:01 AM
Aashaka claimed this task.Mar 10 2016, 1:13 PM
Aashaka removed Aashaka as the assignee of this task.Mar 14 2016, 12:22 PM
Aashaka added a subscriber: Aashaka.

Change 278696 had a related patch set uploaded (by Galorefitz):
Move direct text formatting from i18n messages to HTML in PHP

https://gerrit.wikimedia.org/r/278696

Aashaka removed a subscriber: Aashaka.Mar 21 2016, 6:17 AM

@Anomie raised an issue in the Gerrit patch:

Further, the difficulty with a change like this is what happens when a wiki *doesn't* want whatever formatting you're forcing here? For example, the English Wikipedia overrides both of these messages to replace them with something completely different, that makes absolutely no sense when wrapped in <strong> or <i>.

Comments?

By the way, if the patch wrapped the message in a class instead and used CSS to style it, would a wiki (such as enwiki in your case) generally be open to changing the styling in the CSS file?

Framawiki moved this task from Backlog to Doing on the good first bug board.Dec 2 2017, 1:35 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptDec 2 2017, 1:35 PM