Page MenuHomePhabricator

Do not format messages by direct formatting, wrap them in classed/id'ed element instead
Open, LowPublic

Description

Messages

scribunto-doc-page-does-not-exist

''Documentation for this module may be created at [[$1]]''

scribunto-doc-page-header

'''This is the documentation page for [[$1]]'''

contain direct formatting and are not wrapped in element with class/id thus are (easily) unstyleable.

Messages should contain plaintext as much as possible and be wrapped in element with class/id to be styleable. Please remove the formatting in messages and add the wrapping of them in the hook handling.


Version: unspecified
Severity: trivial
Whiteboard: usability

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:16 AM
bzimport set Reference to bz46109.
bzimport added a subscriber: Unknown Object (MLST).
Aashaka added a subscriber: Aashaka.

Change 278696 had a related patch set uploaded (by Galorefitz):
Move direct text formatting from i18n messages to HTML in PHP

https://gerrit.wikimedia.org/r/278696

@Anomie raised an issue in the Gerrit patch:

Further, the difficulty with a change like this is what happens when a wiki *doesn't* want whatever formatting you're forcing here? For example, the English Wikipedia overrides both of these messages to replace them with something completely different, that makes absolutely no sense when wrapped in <strong> or <i>.

Comments?

By the way, if the patch wrapped the message in a class instead and used CSS to style it, would a wiki (such as enwiki in your case) generally be open to changing the styling in the CSS file?

Removing task assignee due to inactivity, as this open task has been assigned to the same person for more than two years (see the emails sent to the task assignee on Oct27 and Nov23). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.
(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

Change 278696 abandoned by Thiemo Kreuz (WMDE):
[mediawiki/extensions/Scribunto@master] Move direct text formatting from i18n messages to HTML in PHP

Reason:
5 years old. User appears to be inactive. Please feel free to reopen this patch if I made a mistake.

https://gerrit.wikimedia.org/r/278696