Page MenuHomePhabricator

"You have new messages" does not appear for anonymous users
Closed, ResolvedPublic

Description

Author: nyenyec

Description:
In MediaWiki 1.5beta3 the "You have new messages" box does not appear for
anonymous users any more.

When I'm logged in I do get message notifications, but for "User
talk:XXX.XXX.XXX.XXX" (i.e. IP addresses), there is no message notification.

This used to work with 1.4.

I tested this in HuWiki and EnWiki.


Version: 1.5.x
Severity: normal

Details

Reference
bz2825

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 8:40 PM
bzimport set Reference to bz2825.
bzimport added a subscriber: Unknown Object (MLST).

I confirm this bug in the current (CVS) version of beta3 and - unfortunately
also in my EnotifWiki version.
I'll have a look into that problem in the next hours.

grin added a comment.Jul 12 2005, 8:28 PM

22:15:54 < Hashar> grin> about 70% of wikipedia traffic is from anonymous users,
we cache pages

generated for them with Squid-cache

22:16:09 < Hashar> grin> so we dont want to invalidate a page for all anonymous
users when one anon

receive a message :p

I raised priority to high, because this is (in my opinion) a quite vital feature
of MediaWiki - in the Wikipedia context.
If someone is of another opinion, pls. can he or she silently decrease the
Priority ? thanks.

(In reply to comment #2)

22:15:54 < Hashar> grin> about 70% of wikipedia traffic is from anonymous users,
we cache pages

generated for them with Squid-cache

22:16:09 < Hashar> grin> so we dont want to invalidate a page for all anonymous
users when one anon

receive a message :p

Hashar; please can you elaborate on that ?
The feature should work, but it does not.

Talked a bit about it with tom.
It's indeed a bug, most probably in Article::editUpdates() a case is not
handled when a user:: object is created with an ip address string.

Article.php rev.1.355 lines 2023..2034:

perhaps, because User:newFromName($shortTitle)

does return 'null' (because anon isn't a validUser in newFromName() ?

I am not sure. This is, why I ask kindly:
Can someone of the core team pls. fix this ?

Fixed, now creates IP users manually and it works.

Brion,

I confirm, that your patch in Article.php

$other = new User(); $other->setName($shortTitle);

fixed that problem.
Thanks