Page MenuHomePhabricator

survey not compatible with SQLite
Closed, ResolvedPublic

Description

20:16:35 A database query syntax error has occurred.
20:16:35 The last attempted database query was:
20:16:35 "CREATE TABLE IF NOT EXISTS surveys (
20:16:35 survey_id INTEGER NOT NULL AUTOINCREMENT PRIMARY KEY,
20:16:35 survey_name TEXT NOT NULL, -- String indentifier for the survey
20:16:35 survey_title TEXT NOT NULL, -- Title of the survey
20:16:35 survey_enabled INTEGER NOT NULL default '0', -- If the survey can be taken by users
20:16:35 survey_header TEXT NOT NULL, -- Text to display above the survey
20:16:35 survey_footer TEXT NOT NULL, -- Text to display below the survey
20:16:35 survey_thanks TEXT NOT NULL, -- Text to display after survey submission
20:16:35 survey_user_type INTEGER NOT NULL default '0', -- Type of users that can participate in the survey
20:16:35 survey_namespaces BLOB NOT NULL, -- Namespaces on which the survey can be displayed
20:16:35 survey_ratio INTEGER NOT NULL, -- Percentage of users to show the survey to
20:16:35 survey_expiry INTEGER NOT NULL, -- Coockie expiry time for the survey
20:16:35 survey_min_pages INTEGER NOT NULL -- Min amount of pages the user needs to view before getting the survey
20:16:35 )"
20:16:35 from within function "DatabaseBase::sourceFile( /var/lib/jenkins/jobs/mwext-Survey-testextensions-master/workspace/extensions/Survey/sql/Survey.sql )".
20:16:35 Database returned error "1: near "AUTOINCREMENT": syntax error"


Version: master
Severity: minor

Details

Reference
bz46433

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:38 AM
bzimport set Reference to bz46433.
hashar created this task.Mar 21 2013, 8:22 PM
demon added a comment.Mar 21 2013, 8:24 PM

s/AUTOINCREMENT/AUTO_INCREMENT/

This is what the code on master looks like:

CREATE TABLE IF NOT EXISTS /*_*/surveys (

survey_id                SMALLINT unsigned   NOT NULL auto_increment PRIMARY KEY,
survey_name              VARCHAR(255)        NOT NULL, -- String indentifier for the survey
survey_title             VARCHAR(255)        NOT NULL, -- Title of the survey
survey_enabled           TINYINT             NOT NULL default '0', -- If the survey can be taken by users
survey_header            TEXT                NOT NULL, -- Text to display above the survey
survey_footer            TEXT                NOT NULL, -- Text to display below the survey
survey_thanks            TEXT                NOT NULL, -- Text to display after survey submission
survey_user_type         TINYINT unsigned    NOT NULL default '0', -- Type of users that can participate in the survey
survey_namespaces        BLOB                NOT NULL, -- Namespaces on which the survey can be displayed
survey_ratio             TINYINT unsigned    NOT NULL, -- Percentage of users to show the survey to
survey_expiry            INT unsigned        NOT NULL, -- Coockie expiry time for the survey
survey_min_pages         TINYINT unsigned    NOT NULL -- Min amount of pages the user needs to view before getting the survey

) /*$wgDBTableOptions*/;

Tests passed, thank you!