Page MenuHomePhabricator

Make all PHPUnit test providers public static
Closed, ResolvedPublic


Some tests have static data provider. It seems that the required phpunit version also allows using of non-static and non-public dataProvider.

Clean up is a good idea here.

Version: 1.21.x
Severity: minor



Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 1:38 AM
bzimport set Reference to bz46434.


The convention is "public static function" for data providers. I cleaned this up in November (Ic55d539b9a58f448b5 / I9d2b148e57b).

Whomever merged stuff that doesn't do that is naughty (oh!)

Change-Id: I30e5efcd88c516121c454676bd7a18f9b7c8fca6

(In reply to comment #2)

Change-Id: I30e5efcd88c516121c454676bd7a18f9b7c8fca6

successfully merged