Page MenuHomePhabricator

Special:ProtectedPages results in whitepage when a bad title is protected
Closed, ResolvedPublic


Ran into this on -- SpecialProtectedPages.php doesn't check the result of Title::makeTitleSafe(), so when it returns null (as it does if an error occurs) then [[Special:ProtectedPages]] errors out.

Version: 1.19.4
Severity: normal



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:14 AM
bzimport set Reference to bz46493.
bzimport added a subscriber: Unknown Object (MLST).

Maybe someone can run the cleanupTitles.php maintenance script on that wiki to fix the broken rows.

commited a alternative with gerrit 56125

(In reply to comment #3)

commited a alternative with Gerrit change #56125

successfully merged, so FIXED in master

Related URL: (Gerrit Change Iaa6e3378c185c53b77a4ede0ddfdfed8c6a2268a)

oops, need to check that this is in 1.19

Related URL: (Gerrit Change Iaa6e3378c185c53b77a4ede0ddfdfed8c6a2268a)

Change 62608 abandoned by MarkAHershberger:
Handle invalid titles on ProtectedPages and ProtectedTitles

clean up