If web notifications are turned off the yellow bar of death does not return
Closed, ResolvedPublic

Description

Need to make sure that the yellow bar works when web notifications are turned off.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=47743

bzimport added a project: Echo.Via ConduitNov 22 2014, 1:18 AM
bzimport added a subscriber: Unknown Object (MLST).
bzimport set Reference to bz46550.
kaldari created this task.Via LegacyMar 25 2013, 10:01 PM
bzimport added a comment.Via ConduitApr 13 2013, 1:55 AM

bsitu wrote:

This seems to work fine but the problem is that option echo-notify-hide-link disappears in preference

bzimport added a comment.Via ConduitApr 13 2013, 2:25 AM

bsitu wrote:

(In reply to comment #1)

This seems to work fine but the problem is that option echo-notify-hide-link
disappears in preference

Never mind, looks like both echo-pref-notify-hide-link and echo-notify-link are not used anymore, I submitted a patch to clean them up: https://gerrit.wikimedia.org/r/#/c/59024/

gerritbot added a comment.Via ConduitApr 14 2013, 10:33 PM

Related URL: https://gerrit.wikimedia.org/r/59086 (Gerrit Change Ifc8fbaf8fdc96f9c18c2a889d2e854e49b3a7010)

kaldari added a comment.Via ConduitApr 14 2013, 10:37 PM

Fixed in Echo change If21f3aac and core change Ifc8fbaf8. Waiting for review.

gerritbot added a comment.Via ConduitApr 18 2013, 6:57 PM

Related URL: https://gerrit.wikimedia.org/r/59876 (Gerrit Change Ifc8fbaf8fdc96f9c18c2a889d2e854e49b3a7010)

Add Comment