Page MenuHomePhabricator

Wikipedia icon is shown for other sites
Closed, ResolvedPublic

Description

The Wikipedia icon is shown when you sign up for other sites (e.g. MediaWiki.org). This is because the 'w' icon (modules/icons/W.png) is hard-coded to Wikipedia.

A simple approach to fixing this is to use the favicon, but there are other ways to do it.


Version: master
Severity: normal

Details

Reference
bz46585

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:20 AM
bzimport added a project: Notifications.
bzimport set Reference to bz46585.

bsitu wrote:

Probably we should just use a better icon for signup, I don't see how a W icon is related to signup, there is also a placeholder icon for default.

CCing the designer.

Im not sure what the context of the bug is.
Can you please explain which primary instance you are referring to/ add a screenshot or something?

For example, when someone creates a new account on MediaWiki.org, they get a Welcome notification. The Welcome notification, like all system notifications, shows a "W" icon next to it. The "W" icon isn't appropriate in the context of MediaWiki.org since MediaWiki.org has it's own logo that doesn't involve any Ws. I was thinking that we could implement 2 possible solutions:

  1. Just use a generic 'info' icon for all system messages on all wikis and get rid of the 'W' icon.
  1. Use a generic 'info' icon for all system messages by default, but override this with a 'W' icon on English Wikipedia and possibly provide overrides for other wikis as well.
  1. Figure out a way to use each wiki's logo as the icon for system messages.

Vibha: Which of these would be your first choice? Which would be your second choice?

Foremost: the point of Notifications is to increase engagement and editing on WIKIPEDIA. So if identity and context on Wikipedia are compromised for other projects, it will be a very shortsighted approach to the problem and will defeat some of our larger purposes.

First choice is 2 >
Use the W as a default symbol.
Other projects can over-ride the W
as long as over-riding icons employ the right size.
ICON SIZE is critical here, else it will break the hierarchy of information.

Next Option is 3, which I assume is more work.

Option 1 is not an option. Informational messages can be really confusing in a notifications stack, why are they temporal. This solution also doesn't scale cognitively, Welcome is not just informational, its very much about brand and signup acknowledgement.

  • Bug 47650 has been marked as a duplicate of this bug. ***

(In reply to comment #5)

Foremost: the point of Notifications is to increase engagement and editing on
WIKIPEDIA. So if identity and context on Wikipedia are compromised for other
projects, it will be a very shortsighted approach to the problem and will
defeat some of our larger purposes.

No one is suggesting Wikipedia not be able to show their icon. However, I don't think there's a reason to *only* allow Wikipedia to.

And people are already having issues with the default icon currently in use. But any default site icon is probably not going to work for all sites. And it looks like no one has changed wmf-config to put the Wikipedia icon there even on Wikipedia. Hence, reopening.

Here's one way to do option 3:

  1. Have a variable for the path a 30x30 site icon (like the favicon, but with the right dimensions).
  2. Use that vaiable on all sites (including of course the Wikipedias).
  3. Use img tags instead of a background-image for the icons (allows changing the URL without needing a new CSS ruleset). This will help make this simpler, and also make it easier for other extensions to extend Echo. See https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/GettingStarted.git;a=blob;f=resources/ext.gettingstarted.echo.css;h=187c55b3a8e7fc354aa8ee5bb2e58eb72c15a53e;hb=refs/heads/master . If it uses an img tag, we can just pass that in.

I already played around with it. A float: left and appropriate margin should do the trick. I can help implement this if you want.

The only part that requires some care is coordinating deployment of any other extensions to Echo that use their own icon classes (e.g. GettingStarted above).

Due to the very limited amount of time available and the low priority of this bug, I was planning on just implementing the solution described in bug 47662 (option 2). If you'd like to implement option 3 instead, I won't object :) I suppose you could have a reserved key for the icon parameter called 'site' that is handled differently than all the other icons. Just make sure it works in monobook or some people will not be happy.

I can take it, as long as you're okay with me changing the icons to use img tags.

(In reply to comment #5)

Foremost: the point of Notifications is to increase engagement and editing on
WIKIPEDIA. So if identity and context on Wikipedia are compromised for other
projects, it will be a very shortsighted approach to the problem and will
defeat some of our larger purposes.

Hurrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr.

Related URL: https://gerrit.wikimedia.org/r/61341 (Gerrit Change Ifc02b653d07de19229dfb2604305e32f3bd595fe)

Related URL: https://gerrit.wikimedia.org/r/61342 (Gerrit Change I84c7a92917f7a14e865a6a4bc9aff643f7cfba77)

Related URL: https://gerrit.wikimedia.org/r/61343 (Gerrit Change I2c8c086fb5f4a6c5618039908fed188522c864c5)

Related URL: https://gerrit.wikimedia.org/r/61344 (Gerrit Change I0f15498ab1fba239bce141b178340a9d9984bedf)

The first (61341) is the main change (everything else relies on that). It basically makes the icons img tags (rather than background-images), which makes it easier to customize, both for other extensions and the site.

To customize it for a site, it's just:

$wgEchoNotificationIcons['site']['url'] = "some url";

This can be incorporated into the WMF's wiki-specific config as well, so every wiki can get its own icon.

It also lets other extensions add icons easily without changing CSS. The icons are passed into the BeforeCreateEchoEvent hook in a new parameter.

None of the other two extensions I know of extending Echo (PageTriage and Thanks) define any new icons, so I just added the new hook parameter.

For a live example with the changes, see http://piramido.wmflabs.org/ . If you sign up and confirm an email, you can see both a built-in icon and one defined by GettingStarted.

(In reply to comment #15)

For a live example with the changes, see http://piramido.wmflabs.org/ .

Easier link: http://piramido.wmflabs.org/wiki/Special:CreateAccount.

Main change, Thanks, and PageTriage merged.

I'll queue up the wmf-config change.

Related URL: https://gerrit.wikimedia.org/r/61348 (Gerrit Change I4b14d22c624b6d63bfd97a3b09e7ef98d5a47bab)

Related URL: https://gerrit.wikimedia.org/r/61349 (Gerrit Change Ic0e29cf8284efc87e2ce67434a5d7984ee760659)

61348 is the wmf-config change (for when the Echo one is deployed). It still needs a MW icon, since I was having trouble finding the right one to scale.

61349 removes the unused W.png (meant to do that in the main Echo commit).

  • Bug 50638 has been marked as a duplicate of this bug. ***