We need to decide on the Change LESS compilation library RfC.
Description
Description
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | ori | T112035 lessphp performance is catastrophically bad | |||
Resolved | ori | T486 RfC: Change LESS compilation library | |||
Resolved | • dpatrick | T112329 Security review for oyejorge/less.php | |||
Resolved | • Mattflaschen-WMF | T113313 GettingStarted issue with less.php |
Event Timeline
Comment Actions
This RfC has been scheduled for next week: https://www.mediawiki.org/wiki/Architecture_committee/2014-10-01
Comment Actions
Discussed on 2014-10-08.
Change LESS compilation library | RFC meeting | https://meta.wikimedia.org/wiki/IRC_office_hours | Please note: Channel is logged and publicly posted (DO NOT REMOVE THIS NOTE) | Logs: http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-office/ (TimStarling, 21:03:14) https://www.mediawiki.org/wiki/Requests_for_comment/Change_LESS_compilation_library (TimStarling, 21:03:22) https://www.apache.org/licenses/GPL-compatibility.html (DanielK_WMDE__, 21:10:30) https://github.com/oyejorge/less.php/issues/168#issuecomment-55478059 it looks like it got forked? (legoktm, 21:12:47) https://github.com/less/less.js/issues/1029 (TrevorParscal, 21:15:49) https://github.com/Less-PHP/less.php/blob/master/composer.json (legoktm, 21:16:22) <TrevorParscal> step 1: to resolve the licensing by either getting the less.php to become compatible, or rounding up and resolving all non "or later" uses of GPLv2 in our own software (TimStarling, 21:28:02) <TrevorParscal> step 2: have a mergable patch for less.php to restore custom functions (maybe offer it upstream) (TimStarling, 21:28:14) bd808 votes for composer (TimStarling, 21:28:30)
TODO according to trevor:
- step 1: to resolve the licensing by either getting the less.php to become compatible, or rounding up and resolving all non "or later" uses of GPLv2 in our own software
- step 2: have a mergable patch for less.php to restore custom functions (maybe offer it upstream)
This comment was removed by Paladox.
Comment Actions
cssjanus/cssjanus and CSSMin are both Apache-licensed. I think we should not worry about it. I will wager that no one substantially involved with either MediaWiki or less.php would be injured by the interoperation of these two software projects.
- step 2: have a mergable patch for less.php to restore custom functions (maybe offer it upstream)
Custom functions are gone, as of rMWe176c76da2d8: resourceloader: Fully remove ResourceLoaderLESSFunctions.