Page MenuHomePhabricator

LQT: "Call to a member function getTitle() on a non-object" accessing an history entry with "Comment text edited (since deleted)"
Closed, ResolvedPublicPRODUCTION ERROR

Description

[02-Apr-2013 00:10:30] Fatal error: Call to a member function getTitle() on a non-object at /usr/local/apache/common-local/php-1.22wmf1/extensions/LiquidThreads/classes/View.php on line 108
Server: mw1178
Method: GET
URL: http://www.mediawiki.org/w/index.php?title=Thread:Talk:User_hub/Deletion_Wikisupplier_page&lqt_oldid=30913
Backtrace:
#0 /usr/local/apache/common-local/php-1.22wmf1/extensions/LiquidThreads/classes/View.php(108): LqtView::permalinkData()
#1 /usr/local/apache/common-local/php-1.22wmf1/extensions/LiquidThreads/classes/View.php(125): LqtView::permalinkData(Object(Thread), NULL, NULL)
#2 /usr/local/apache/common-local/php-1.22wmf1/extensions/LiquidThreads/classes/View.php(230): LqtView::permalink(Object(Thread), 'diff', NULL, NULL, NULL, Array, Array)
#3 /usr/local/apache/common-local/php-1.22wmf1/extensions/LiquidThreads/pages/ThreadHistoricalRevisionView.php(91): LqtView::diffPermalink(Object(Thread), 'diff', Object(ThreadRevision))
#4 /usr/local/apache/common-local/php-1.22wmf1/extensions/LiquidThreads/pages/ThreadHistoricalRevisionView.php(58): ThreadHistoricalRevisionView->getChangeDescription()
#5 /usr/local/apache/common-local/php-1.22wmf1/extensions/LiquidThreads/pages/ThreadHistoricalRevisionView.php(119): ThreadHistoricalRevisionView->showHistoryInfo()
#6 /usr/local/apache/common-local/php-1.22wmf1/extensions/LiquidThreads/classes/Dispatch.php(100): ThreadHistoricalRevisionView->show()
#7 /usr/local/apache/common-local/php-1.22wmf1/extensions/LiquidThreads/classes/Dispatch.php(220): LqtDispatch::threadPermalinkMain(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest))
#8 [internal function]: LqtDispatch::tryPage(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest), Object(MediaWiki))
#9 /usr/local/apache/common-local/php-1.22wmf1/includes/Hooks.php(255): call_user_func_array('LqtDispatch::tr...', Array)
#10 /usr/local/apache/common-local/php-1.22wmf1/includes/GlobalFunctions.php(3841): Hooks::run('MediaWikiPerfor...', Array)
#11 /usr/local/apache/common-local/php-1.22wmf1/includes/Wiki.php(422): wfRunHooks('MediaWikiPerfor...', Array)
#12 /usr/local/apache/common-local/php-1.22wmf1/includes/Wiki.php(305): MediaWiki->performAction(Object(Article), Object(Title))
#13 /usr/local/apache/common-local/php-1.22wmf1/includes/Wiki.php(565): MediaWiki->performRequest()
#14 /usr/local/apache/common-local/php-1.22wmf1/includes/Wiki.php(458): MediaWiki->main()
#15 /usr/local/apache/common-local/php-1.22wmf1/index.php(59): MediaWiki->run()
#16 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#17 {main}


Version: master
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:34 AM
bzimport set Reference to bz46767.
bzimport added a subscriber: Unknown Object (MLST).
hashar lowered the priority of this task from Medium to Low.Jun 1 2015, 1:33 PM
hashar added a subscriber: hashar.

It still happens from time to time. Seems the issue is trying to access an history item which has the activity "Comment text edited (since deleted)"

Looking at Thread:Talk:User_hub/Deletion_Wikisupplier_page history page.

There is one Comment text edited (since deleted) which is lqt_oldid=30913.

The Thread:Project_talk:Support_desk/Asp_Project_ADODB.Connection_is_returning_null_after_media-wiki_installation history page also has a Comment text edited (since deleted) revision: lqt_oldid=24716.

hashar renamed this task from LQT: Call to a member function getTitle() on a non-object to LQT: "Call to a member function getTitle() on a non-object" accessing an history entry with "Comment text edited (since deleted)".Jun 1 2015, 1:34 PM
hashar moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.

Semi regularly happens in translatewiki.net:

2016-03-29 12:17:39 translatewiki.net translatewiki_net-bw_: [c0c79968] /w/i.php?title=Thread:Support/Request_for_enabling_new_variants_for_Min_Dong_Chinese_language&lqt_oldid=58185
BadMethodCallException from line 108 of /srv/mediawiki/tags/2016-03-25_14:03:34/extensions/LiquidThreads/classes/View.php: Call to a member function getTitle() on a non-object (null)
#0 /srv/mediawiki/tags/2016-03-25_14:03:34/extensions/LiquidThreads/classes/View.php(125): LqtView::permalinkData(Thread, NULL, NULL)
#1 /srv/mediawiki/tags/2016-03-25_14:03:34/extensions/LiquidThreads/classes/View.php(230): LqtView::permalink(Thread, string, NULL, NULL, NULL, array, array)
#2 /srv/mediawiki/tags/2016-03-25_14:03:34/extensions/LiquidThreads/pages/ThreadHistoricalRevisionView.php(90): LqtView::diffPermalink(Thread, string, ThreadRevision)
#3 /srv/mediawiki/tags/2016-03-25_14:03:34/extensions/LiquidThreads/pages/ThreadHistoricalRevisionView.php(57): ThreadHistoricalRevisionView->getChangeDescription()
#4 /srv/mediawiki/tags/2016-03-25_14:03:34/extensions/LiquidThreads/pages/ThreadHistoricalRevisionView.php(118): ThreadHistoricalRevisionView->showHistoryInfo()
#5 /srv/mediawiki/tags/2016-03-25_14:03:34/extensions/LiquidThreads/classes/Dispatch.php(101): ThreadHistoricalRevisionView->show()
#6 /srv/mediawiki/tags/2016-03-25_14:03:34/extensions/LiquidThreads/classes/Dispatch.php(223): LqtDispatch::threadPermalinkMain(OutputPage, Article, Title, User, WebRequest)
#7 /srv/mediawiki/tags/2016-03-25_14:03:34/includes/Hooks.php(195): LqtDispatch::tryPage(OutputPage, Article, Title, User, WebRequest, MediaWiki)
#8 /srv/mediawiki/tags/2016-03-25_14:03:34/includes/MediaWiki.php(476): Hooks::run(string, array)
#9 /srv/mediawiki/tags/2016-03-25_14:03:34/includes/MediaWiki.php(288): MediaWiki->performAction(Article, Title)
#10 /srv/mediawiki/tags/2016-03-25_14:03:34/includes/MediaWiki.php(738): MediaWiki->performRequest()
#11 /srv/mediawiki/tags/2016-03-25_14:03:34/includes/MediaWiki.php(519): MediaWiki->main()
#12 /srv/mediawiki/tags/2016-03-25_14:03:34/index.php(43): MediaWiki->run()
#13 {main}

Change 280207 had a related patch set uploaded (by Nikerabbit):
Avoid fatal when viewing history for deleted reply

https://gerrit.wikimedia.org/r/280207

Change 280207 merged by jenkins-bot:
Avoid fatal when viewing history for deleted reply

https://gerrit.wikimedia.org/r/280207

Nikerabbit claimed this task.

If the history of this bug is to be trusted, almost exactly three years passed from reporting to closure. And this is not April fools :)

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:12 PM