If the inline comments were included (or had an option to be included) in the main cover comment, it'd be a lot easier to follow them. Links to the specific patchset file position in which they are placed would also make it a lot easier to get to them.
As it is (2 inline comments) just is not that useful.
Version: wmf-deployment
Severity: normal
URL: https://code.google.com/p/gerrit/issues/detail?id=93
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • demon | T48792 Gerrit should include summaries of and links to inline comments in the cover comment | |||
| Resolved | • demon | T70271 Upgrade gerrit to 2.12 | |||
| Declined | Bawolff | T106666 Consider changing gerrit default change screen to CHANGE_SCREEN2 | |||
| Resolved | jcrespo | T139755 Need snapshot of 'reviewdb' on spare machine to test gerrit schema upgrades | |||
| Resolved | • demon | T131903 Update gerrit sshkey in role::ci::slave::labs when upgrade to Jessie happens | |||
| Resolved | Dzahn | T125018 replace gerrit server (ytterbium) with jessie server (lead) | |||
| Resolved | RobH | T123132 Need spare server to upgrade/migrate gerrit | |||
| Resolved | • Cmjohnson | T123531 check for memory upgrade for lead | |||
| Resolved | • demon | T126794 setup/deploy server lead as jessie gerrit server | |||
| Resolved | • Cmjohnson | T141415 decom ytterbium (datacenter) |
The workflow is especially difficult when you have responded to existing comments on Patch Set N and then someone new comments on the same patch set. It seems the best you can do is visit every file in the patch set that has comments and Ctrl+F/Ctrl+G to search for the new reviewer's name.
Allegedly fixed upstream (2.9)! \o/ https://code.google.com/p/gerrit/issues/detail?id=93
Worth running any exploding non-stable version or sacrificing entire herds of scapegoats just to have this one feature, IMHO.
I had noticed it was backported to 2.8 but not which point version; Legoktm points out you have to "switch to the new change screen in your prefs" (i.e. https://gerrit.wikimedia.org/r/#/settings/preferences "Change View:"). http://cl.ly/image/0C3e1v0m1u2O
I suppose this bug will be fixed (only) when our server is switched to the new change view then? (And I understood we're not going to do so that soon if ever.)
The new change view has some problems, yeah, but IMO it's an improvement over the current one – it just needs some polish. I switched to it already :)
There is a list of problems with new change view on at http://etherpad.wikimedia.org/p/new-gerrit-change-view-comments (I started it, Legoktm and Isarra contributed), feel free to add items or file them upstream.
It has been fixed in https://gerrit-review.googlesource.com/#/c/51826/
And we will be upgrading to gerrit 2.12 soon anyways.