Page MenuHomePhabricator
Create Task
Maniphest T48848

Links/URLs inside of collapsible toggles don't work, only expands/collapses
Closed, ResolvedPublic
Actions

Description

Bug 28344 is back. It was fixed before in r90239, but some recent update made it reapear.

Version: 1.21.x
Severity: normal
URL: https://en.wikibooks.org/wiki/Special:ExpandTemplates?input=%3Cdiv+class%3D%22mw-collapsible+mw-collapsed%22%3E%3Cdiv+class%3D%22mw-collapsible-toggle+mw-collapsible-arrowtoggle%22+style%3D%22float%3Anone%3B%22%3E%5B%5BThis+link+is+inside+of+a+collapsible+toggle+element+and+doesn't+work%3A+clicking+on+it+just+expand+the+collapsed+element%5D%5D%3C%2Fdiv%3E%3Cdiv+class%3D%22mw-collapsible-content%22%3E%5B%5BThis+link+works+(but+is+not+in+a+collapsible+toggle)%5D%5D%3C%2Fdiv%3E%3C%2Fdiv%3E&contexttitle=&removecomments=true

Details

Reference
bz46848

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:39 AM
• bzimport added projects: MW-1.21.0-release, MediaWiki-JavaScript.
• bzimport set Reference to bz46848.
He7d3r created this task.Apr 3 2013, 2:23 PM
Aklapper added a comment.Apr 3 2013, 11:20 PM

CC'ing some JS folks.

matmarex added a comment.Apr 4 2013, 4:08 PM

My fault, introduced in Id3f457a8 (I've been rewriting that module for usefulness and performance). I'll submit a fix later today.

matmarex added a comment.Apr 4 2013, 5:39 PM

Patch is Id571f8d6. I'll submit a backport to REL1_21, wmf/1.21wmf12 and wmf/1.22wmf1 once it's merged.

matmarex added a comment.May 3 2013, 3:05 PM

Merged at last. Since this took so long and nobody really complained I won't bother with the WMF backports; this will go out with 1.22wmf4.

gerritbot added a comment.May 3 2013, 3:25 PM

Related URL: https://gerrit.wikimedia.org/r/62156 (Gerrit Change Id571f8d612e5131845d381121604c2b1116a077f)

matmarex added a comment.May 3 2013, 3:35 PM

[Removing "Backport_to_Stable" flag, setting milestone to 1.21 - this is a bug in master and the RC version of 1.21; fixes to both master and REL1_21 branches were merged. AFAIK the flag only applies to released versions, that is currently 1.20 and earlier.]

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL