Page MenuHomePhabricator

OutputPage: Inline module state for site/user module stuck in "loading" if module is filtered out
Closed, ResolvedPublic


OutputPage::getScriptsForBottomQueue sets state=loading if $wgUseSiteJs = true, and adds result of calling makeResourceLoaderLink() to the $scripts list.

However there is a case where makeResourceLoaderLink() will return an empty string (instead of a script tag loading the scripts of the site module) - namely the filter loop in makeResourceLoaderLink() rejects it, which is the case on pages like SpcialJavaScriptTest, SpecialPreferences and others that disallow modules from the user land.

Version: 1.21.x
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:40 AM
bzimport set Reference to bz46857.

Change-Id: I46b5bc6f714abe4b66186d7b7a14c69195f00ee1