Page MenuHomePhabricator

Missing or useless links in Echo talk page notification e-mails and on wiki
Closed, ResolvedPublic

Description

Sample message:


MediaWiki user Steven (WMF) posted on your talk page:

/* Productization vs. Integration */

View more:

http://www.mediawiki.org/wiki/User_talk:MZMcBride


To control which emails we send you, visit:
http://www.mediawiki.org/wiki/Special:Preferences#mw-prefsection-echo

Wikimedia Foundation, 149 New Montgomery St., 3rd Fl., San Francisco, CA 94105.


Ideally the link would be https://www.mediawiki.org/wiki/User_talk:MZMcBride#Productization_vs._Integration.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=47707
https://bugzilla.wikimedia.org/show_bug.cgi?id=47954
https://bugzilla.wikimedia.org/show_bug.cgi?id=48183

Details

Reference
bz46937

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:17 AM
bzimport added a project: Notifications.
bzimport set Reference to bz46937.
MZMcBride created this task.Apr 6 2013, 1:19 AM

Even the link on the notification popup should also be corrected similarly.

Rethinking I figured that the section links are not always there. Sometimes a user just posts without creating a new section. I don't think Echo handles these edits any differently so its not so easily possible and more in the direction of WONTFIX.

Alternatively we can point to the diff as MW's watching emails;for example: http://www.mediawiki.org/w/index.php?title=User_talk:Nischayn22&diff=next&oldid=563821

(In reply to comment #2)

Rethinking I figured that the section links are not always there. Sometimes a
user just posts without creating a new section. I don't think Echo handles
these edits any differently so its not so easily possible and more in the
direction of WONTFIX.

Special:Notifications "solves" this by parsing the edit summary so that the automatic edit summary links to the section.

Alternatively we can point to the diff as MW's watching emails;for example:
http://www.mediawiki.org/w/index.php?title=User_talk:
Nischayn22&diff=next&oldid=563821

Yes please.

(In reply to comment #1)

Even the link on the notification popup should also be corrected similarly.

That was filed as bug 47954, dunno if it makes sense to separate.

Related URL: https://gerrit.wikimedia.org/r/63789 (Gerrit Change I161e2ffda2f2540f64de90cc621fb3b69479d0db)

Is there anything in this bug that is separate from bug 47954? Do we want to change this bug to something like "Add diff links in emails"?

It looks like difflink was already seperated into bug 48183. As far as i can read this and bug 47954 look to be duplicates of each other, although with the long discussion on bug 47954 i wasn't entirely sure what they were going for.

(In reply to comment #6)

Is there anything in this bug that is separate from bug 47954? Do we want to
change this bug to something like "Add diff links in emails"?

Well, the question is whether there needs to be more than one modification here; diffs in the on-wiki notification and a separate request for a diff in the email. bug 48183 seems to be focused on the former, so this one could be focused on the latter, if it requires two separate changes.

(In reply to comment #4)

(In reply to comment #1)

Even the link on the notification popup should also be corrected similarly.

That was filed as bug 47954, dunno if it makes sense to separate.

Apparently not, as the patch is on both.

  • Bug 47954 has been marked as a duplicate of this bug. ***

Changed title to be specific to talk page, since the rest of the bug already was.

The change got merged is this fixed now?

Yes, with that change, it will link to the section if possible, otherwise the whole page. For diff links, see bug 48183.

(In reply to comment #13)

For diff links, see bug 48183.

Is that about email too?

(In reply to comment #14)

Is that about email too?

Yes, Fabrice specifically mentioned an email diff link. https://bugzilla.wikimedia.org/show_bug.cgi?id=48183#c8