Page MenuHomePhabricator

Upgrade jQuery UI from 1.8 to 1.9
Closed, ResolvedPublic

Description

http://jqueryui.com/download/ says 1.10 is stable and 1.9 is legacy, MediaWiki seems to have 1.8! I spent a while figuring out why some parts of jquery.ui.position were not working, until I checked out the version.


Version: 1.22.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=44740

Details

Reference
bz47076

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:26 AM
bzimport set Reference to bz47076.

Had to work around this in Translate: https://gerrit.wikimedia.org/r/58521

  • Bug 65520 has been marked as a duplicate of this bug. ***

Unlike jQuery core, jQuery UI has quite a few changes that require modification to existing code to remain compatible.

Almost exclusively simple changes (e.g. result of improving the API). Afaik no things have been dropped or made difficult, but it requires changes.

And we have a shitload of code out there, including the community, so we'll probably need to give them more than 3 weeks (like we did with jQuery core) to do migration.

And.. no official legacy layer to smooth migration. So, not sure how we're going to tackle this.

Upgrade guides:

(In reply to Krinkle from comment #3)

And.. no official legacy layer to smooth migration. So, not sure how we're
going to tackle this.

http://jqueryui.com/upgrade-guide/1.9/ says: "Although the redesigns introduce breaking changes, 1.9 maintains full compatibility with the 1.8 API by default."

Upgrade guides:

These links are irrelevant, as MediaWiki already uses 1.8.24.

No longer blocks: 65399

You are aware of the fact that jquery.ui 1.8.x makes excessive use of $.browser, which is deprecated and only provided by jquery.migrate?

Wikibase makes extensive use of jQuery UI and I'd love to be able to work with a newer version. If the migration indeed is very hard, we might try to provide both versions side-by-side instead?

(In reply to Michael M. from comment #4)

(In reply to Krinkle from comment #3)

And.. no official legacy layer to smooth migration. So, not sure how we're
going to tackle this.

http://jqueryui.com/upgrade-guide/1.9/ says: "Although the redesigns
introduce breaking changes, 1.9 maintains full compatibility with the 1.8
API by default."

Yeah, I knew that already actually. Forgot about that.

I spoke with Scott Gonzalez and he also re-assured me that really there is nothing stopping us from upgrading to 1.9.

The only major thing being dropped in jQuery UI 1.9 is support for the jQuery UI 1.7 API, which MediaWiki never supported to begin with (jQuery UI 1.8 is the first version that ever shipped with MediaWiki).

Change 137471 had a related patch set uploaded by Krinkle:
Upgrade jQuery UI from 1.8.24 to 1.9.2

https://gerrit.wikimedia.org/r/137471

Adding as a blocker on $.browser bug, per Michael M. (confirmed by grep).

Change 137471 merged by jenkins-bot:
Upgrade jQuery UI from 1.8.24 to 1.9.2

https://gerrit.wikimedia.org/r/137471

  • Bug 66376 has been marked as a duplicate of this bug. ***